Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc: 0.4.25 -> 0.5.0 #50324

Merged
merged 2 commits into from Nov 15, 2018
Merged

solc: 0.4.25 -> 0.5.0 #50324

merged 2 commits into from Nov 15, 2018

Conversation

asymmetric
Copy link
Contributor

Motivation for this change

Updated to newest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 15, 2018

@GrahamcOfBorg build solc

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: solc

Partial log (click to expand)

 #include <immintrin.h>
          ^~~~~~~~~~~~~
compilation terminated.
src/sat/sat_probing.cpp
make: *** [Makefile:182: util/mpz.o] Error 1
make: *** Waiting for unfinished jobs....
src/sat/sat_parallel.cpp
builder for '/nix/store/vd2wkhic8g77izxv659ackh6hcaamic3-z3-4.8.1.drv' failed with exit code 2
cannot build derivation '/nix/store/h5imnjsf31c45l558gw66vyzb0ickc1m-solc-0.5.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/h5imnjsf31c45l558gw66vyzb0ickc1m-solc-0.5.0.drv' failed

it uses x86-only header:

include <immintrin.h>
          ^~~~~~~~~~~~~
compilation terminated.
src/sat/sat_probing.cpp
make: *** [Makefile:182: util/mpz.o] Error 1
make: *** Waiting for unfinished jobs....
src/sat/sat_parallel.cpp
builder for '/nix/store/vd2wkhic8g77izxv659ackh6hcaamic3-z3-4.8.1.drv' failed with exit code 2
cannot build derivation '/nix/store/h5imnjsf31c45l558gw66vyzb0ickc1m-solc-0.5.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/h5imnjsf31c45l558gw66vyzb0ickc1m-solc-0.5.0.drv' failed
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: solc

Partial log (click to expand)

-- Installing: /nix/store/yzzmqzrj020v46dqlra0c3h4xiifr3kb-solc-0.5.0/lib/libsolidity.dylib
-- Installing: /nix/store/yzzmqzrj020v46dqlra0c3h4xiifr3kb-solc-0.5.0/bin/solc
-- Installing: /nix/store/yzzmqzrj020v46dqlra0c3h4xiifr3kb-solc-0.5.0/lib/liblll.dylib
-- Installing: /nix/store/yzzmqzrj020v46dqlra0c3h4xiifr3kb-solc-0.5.0/bin/lllc
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/yzzmqzrj020v46dqlra0c3h4xiifr3kb-solc-0.5.0/lib  /nix/store/yzzmqzrj020v46dqlra0c3h4xiifr3kb-solc-0.5.0/bin
patching script interpreter paths in /nix/store/yzzmqzrj020v46dqlra0c3h4xiifr3kb-solc-0.5.0
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/48f1y9qkkmm3d7byb1zr1d2rlx07v0rm-solc-0.5.0-dev

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: solc

Partial log (click to expand)

shrinking /nix/store/6dxyvp5k929kag0xvz44jp23vari934q-solc-0.5.0/bin/lllc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6dxyvp5k929kag0xvz44jp23vari934q-solc-0.5.0/lib  /nix/store/6dxyvp5k929kag0xvz44jp23vari934q-solc-0.5.0/bin
patching script interpreter paths in /nix/store/6dxyvp5k929kag0xvz44jp23vari934q-solc-0.5.0
checking for references to /build in /nix/store/6dxyvp5k929kag0xvz44jp23vari934q-solc-0.5.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/paj376wsb1zrnf4kl03lhm6xb4fzr7zq-solc-0.5.0-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/paj376wsb1zrnf4kl03lhm6xb4fzr7zq-solc-0.5.0-dev
checking for references to /build in /nix/store/paj376wsb1zrnf4kl03lhm6xb4fzr7zq-solc-0.5.0-dev...
/nix/store/6dxyvp5k929kag0xvz44jp23vari934q-solc-0.5.0

@asymmetric asymmetric deleted the solc branch November 15, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants