Create a networking.proxy option

[ardumont]

Following the discussion from #5021

Code:

• obsolete the nix.proxy option
• add the networking.proxy option
• open a default no_proxy environment variable
• add a rsync option

Tests:

• Manual tests ok.
• Automatic tests added and ok

Note:
Code rebased to the latest code.
I do not know if it's a good idea.

[ardumont]

Hello,

Do I need to squash the commits?

If anything is wrong, I'll adapt the code accordingly.

Cheers,

[lucabrunox]

The idea is good, but I think with an option like that the user expects the proxy to be system-wide and not only for nix. Also I feel networking.envVars is wrong, should mention it's for proxy.

[ardumont]

Hello, while working on gnome3-14 for nix, you still have time (and courage :) to answer in other threads, nice!

The idea is good, but I think with an option like that the user expects the proxy to be system-wide and not only for nix.

What do you mean by system-wide?
It is system-wide for me (because it results in /etc/profile), what did I miss?

Also I feel networking.envVars is wrong, should mention it's for proxy.

Right!
Will fix.

Thanks

[lucabrunox]

Ops didn't see the sessionVariables line. Btw I mean, maybe it's better to call it networking.proxy.envVars or something like that. Not sure.

[ardumont]

Ops didn't see the sessionVariables line.

Ok. Cool.

Btw I mean, maybe it's better to call it networking.proxy.envVars or something like that.

Right again!
Will fix.

Thanks!

[jagajaga]

Nice! That's what I was finding in days.

[ardumont]

@lethalman I called it networking.envVarsProxy because it complained about already defined networking.proxy otherwise... (with networking.proxy.envVars, the prefix is the same and it seems to be problematic)

[ardumont]

Nice! That's what I was finding in days.

Do you mean looking for?
Great news then!

Cheers,

[jagajaga]

Hah, yeah. Sorry for my english.

2014-11-21 0:16 GMT+03:00 Antoine R. Dumont notifications@github.com:

Nice! That's what I was finding in days.

Do you mean looking for?
Great news then!

Cheers,

—
Reply to this email directly or view it on GitHub
#5058 (comment).

Sincerely,
Arseniy Seroka

[ardumont]

Sorry for my english.

No problem, just making sure I understood you right :D

[ardumont]

Commits squashed into 1.

[lucabrunox]

Looks good to me in principle, maybe @edolstra has a better name for envVarsProxy?

[ardumont]

Hello,

does anyone has a better name than networking.envVarsProxy?

[wmertens]

How about calling them networking.proxy.default, networking.proxy.http, networking.proxy.https etc.
Then set e.g. http_proxy to networking.proxy.http or networking.proxy.default or don't set it.

[ardumont]

How about calling them networking.proxy.default, networking.proxy.http, networking.proxy.https etc.
Then set e.g. http_proxy to networking.proxy.http or networking.proxy.default or don't set it.

Seems good because that takes into account people that may have more specific configuration.
I'll adapt this then.

Does someone see any other catch?
For example, is the location of networking.proxy (inside config/networking.nix) ok or should it be elsewhere?

Cheers,

[jagajaga]

This location is good.

On November 24, 2014 11:49:25 AM "Antoine R. Dumont"
notifications@github.com wrote:

How about calling them networking.proxy.default, networking.proxy.http,
networking.proxy.https etc.
Then set e.g. http_proxy to networking.proxy.http or
networking.proxy.default or don't set it.

Seems good because that takes into account people that may have more
specific configuration.
I'll adapt this then.

Does someone see any other catch?
For example, is the location of networking.proxy (inside
config/networking.nix) or should it be elsewhere?

Cheers,

---

Reply to this email directly or view it on GitHub:
#5058 (comment)

[ardumont]

This location is good.

Ok. Thanks

[ardumont]

Hello,

After following the multiple suggestions, here is the latest description for this PR:

Code:

• obsolete the nix.proxy option (an information message will appear when building with it).
• add the networking.proxy.default option which is the equivalent of the old nix.proxy (+ new rsync_proxy and no_proxy environment variables).
• add the export of the rsync_proxy environment variable
• open a default no_proxy environment variable
• open http-proxy, https-proxy, rsync-proxy, ftp-proxy and no-proxy options
• when networking.proxy.default is filled, this automatically exports the http_proxy, https_proxy, ftp_proxy, rsync_proxy with this value. This also exports a minimalistic default no_proxy environment variables with 127.0.0.1,localhost.
• when networking.proxy.default is filled and some other specific options (http-proxy, https-proxy, rsync-proxy, ftp-proxy, no-proxy) is declared, all those *_proxy variables are set with the networking.proxy.default value except for the one explicitely specified (which then are filled according to their respective options)
• when networking.proxy.default is empty, only specific proxy environment variable (according to their specific proxy option) will be exported
• if no proxy option is set, then no proxy environment variables is exported.

[ardumont]

I updated the tests scenario to reflect the possibilities.

I do not know what's wrong with the CI though.

[edolstra]

We generally use null rather than an empty string to denote an unset value. I.e.

type = types.nullOr types.str;
default = null;

[ardumont]

ok!

[ardumont]

Great!

Thanks for the feedback!
I'll fix this in the evening, right now I cannot :D

Cheers,

[ardumont]

Tests output:

VM build log

Expand all | Collapse all

    starting VDE switch for network 1
    - running the VM test script
        + starting all VMs
        + machine: running command: env | grep -i proxy
        + machine: running command: su - alice -c 'env | grep -i proxy'
        + machine: must fail: env | grep -i proxy
        + machine: must fail: su - alice -c 'env | grep -i proxy'
        + machine2: running command: env | grep -i proxy
        + machine2: running command: su - alice -c 'env | grep -i proxy'
        + machine2: must succeed: env | grep -i proxy
        + machine2: must succeed: su - alice -c 'env | grep -i proxy'
        + machine3: running command: env | grep -i proxy
        + machine3: running command: su - alice -c 'env | grep -i proxy'
        + machine3: must succeed: env | grep -i http_proxy | grep 123
        + machine3: must succeed: env | grep -i https_proxy | grep 456
        + machine3: must succeed: env | grep -i rsync_proxy | grep 789
        + machine3: must succeed: env | grep -i ftp_proxy | grep 101112
        + machine3: must succeed: env | grep -i no_proxy | grep 131415
        + machine3: must succeed: su - alice -c 'env | grep -i http_proxy | grep 123'
        + machine3: must succeed: su - alice -c 'env | grep -i https_proxy | grep 456'
        + machine3: must succeed: su - alice -c 'env | grep -i rsync_proxy | grep 789'
        + machine3: must succeed: su - alice -c 'env | grep -i ftp_proxy | grep 101112'
        + machine3: must succeed: su - alice -c 'env | grep -i no_proxy | grep 131415'
        + machine4: running command: env | grep -i proxy
        + machine4: running command: su - alice -c 'env | grep -i proxy'
        + machine4: must succeed: env | grep -i http_proxy | grep 000
        + machine4: must succeed: env | grep -i https_proxy | grep 000
        + machine4: must succeed: env | grep -i rsync_proxy | grep 123
        + machine4: must succeed: env | grep -i ftp_proxy | grep 000
        + machine4: must succeed: env | grep -i no_proxy | grep 131415
        + machine4: must succeed: su - alice -c 'env | grep -i http_proxy | grep 000'
        + machine4: must succeed: su - alice -c 'env | grep -i https_proxy | grep 000'
        + machine4: must succeed: su - alice -c 'env | grep -i rsync_proxy | grep 123'
        + machine4: must succeed: su - alice -c 'env | grep -i ftp_proxy | grep 000'
        + machine4: must succeed: su - alice -c 'env | grep -i no_proxy | grep 131415'
    + collecting coverage data
    + syncing
    + cleaning up