Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia_legacy_340: update to make it compatible with current kernel #50841

Merged
merged 1 commit into from Nov 25, 2018

Conversation

florianjacob
Copy link
Contributor

Motivation for this change

The nvidia_legacy_340 version currently in NixOS is incompatible with pkgs.linuxPackages_latest, see #50707 for details.
This update to 340.107 fixes the compilation of the kernel module.

Fixes #50707.

As this is broken on 18.09 stable as well and the legacy versions only get bugfixes, I'd argue that backporting makes sense.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 23, 2018
@c0bw3b c0bw3b merged commit 7fc8692 into NixOS:master Nov 25, 2018
@florianjacob florianjacob deleted the nvidia_legacy_340 branch November 26, 2018 09:05
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvidiaLegacy340 broken on 18.09 with Linux 4.19.2
4 participants