Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpcap: 1.8.1 -> 1.9.0 #51216

Merged
merged 3 commits into from Dec 4, 2018
Merged

libpcap: 1.8.1 -> 1.9.0 #51216

merged 3 commits into from Dec 4, 2018

Conversation

locallycompact
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 29, 2018

Hello and thanks for the contribution.
Please take a peek at the contributing doc and the manual for PR guidelines.
Check-boxes in the PR template are helpful for review, for example to indicate a local build has been tested on a given platform with/without sandboxing.

Your commit short message should be: libpcap: 1.8.1 -> 1.9.0
Also in this instance, this is going to rebuild a good number of packages (500+ on Linux) so the PR should be targeted at the staging branch.
One last nitpick while we're at it: meta.homepage could be updated to https://www.tcpdump.org

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 29, 2018

Changelog for 1.9.0:
https://www.tcpdump.org/libpcap-changes.txt
(no security-related fix AFAICT)

/cc @fpletz as maintainer

@locallycompact locallycompact changed the base branch from master to staging November 29, 2018 11:23
@Mic92 Mic92 changed the title Update libpcap to 1.9.0 libpcap: 1.8.1 -> 1.9.0 Nov 29, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

@GrahamcOfBorg eval

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

@GrahamcOfBorg build libpcap

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

I also get a SHA2-256 hash of 06bhydl4vr4z9c3vahl76f2j96z1fbrcl7wwismgs4sris08inrf locally so I'll correct it. It's possible upstream re-released the tarball.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

@GrahamcOfBorg build libpcap

@c0bw3b c0bw3b merged commit da297ef into NixOS:staging Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants