Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2Packages.rednose: fix build on darwin #51657

Merged
merged 1 commit into from Dec 8, 2018

Conversation

@marsam
Copy link
Contributor

marsam commented Dec 7, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Dec 7, 2018

I don't why, but python2.pkgs.rednose build just fine on staging.

@dotlambda dotlambda changed the title pythonPackages.rednose: fix build python2Packages.rednose: fix build Dec 7, 2018
@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Dec 7, 2018

Actually, why is this even needed? python2.pkgs.rednose also builds on master.

@dotlambda dotlambda closed this Dec 7, 2018
@marsam

This comment has been minimized.

Copy link
Contributor Author

marsam commented Dec 7, 2018

@dotlambda I forgot to mention, it's failing on darwin

@dotlambda dotlambda reopened this Dec 7, 2018
@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Dec 7, 2018

In that case, please only disable the tests on Darwin and amend the commit message.

@marsam marsam force-pushed the marsam:fix-python-rednose-build branch to 6e54e95 Dec 7, 2018
@marsam

This comment has been minimized.

Copy link
Contributor Author

marsam commented Dec 7, 2018

Fixed, thanks for your patience

@Ma27 Ma27 changed the title python2Packages.rednose: fix build python2Packages.rednose: fix build on darwin Dec 8, 2018
@Ma27

This comment has been minimized.

Copy link
Member

Ma27 commented Dec 8, 2018

@marsam I assume you've tested the functionality of the package on darwin (as it can't be confirmed anymore with disabled tests), right? In that case I'm 👍 for merging :)

@marsam

This comment has been minimized.

Copy link
Contributor Author

marsam commented Dec 8, 2018

yes! btw the tests pass, just get stuck in the tearDown methods, specifically in the reload(sys)

@Ma27 Ma27 merged commit 59b6fe3 into NixOS:master Dec 8, 2018
9 checks passed
9 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Ma27

This comment has been minimized.

Copy link
Member

Ma27 commented Dec 8, 2018

@marsam thanks!

@marsam marsam deleted the marsam:fix-python-rednose-build branch Dec 8, 2018
@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented on 6e54e95 Dec 20, 2018

This commit has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/cant-install-nixops-on-my-mac/1710/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.