Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37: remove references to openssl-dev #51724

Closed
wants to merge 1 commit into from
Closed

python37: remove references to openssl-dev #51724

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Dec 8, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member Author

FRidh commented Dec 8, 2018

cc @joachifm

This will need a bit more testing. I would imagine certain packages that provide extension modules to check for these files.

@joachifm
Copy link
Contributor

joachifm commented Dec 8, 2018

Thank you for this.

For future reference, this is what I gathered from the config module:

$ grep -r /nix/store .
./Makefile:INSTALL=     /nix/store/p7amxbz98hxq3siip059qivnincn1mm3-coreutils-8.30/bin/install -c
./Makefile:MKDIR_P=     /nix/store/p7amxbz98hxq3siip059qivnincn1mm3-coreutils-8.30/bin/mkdir -p
./Makefile:prefix=              /nix/store/y78kh4c49qz3m8al5mmxqxanncfs4x0h-python3-3.7.1
./Makefile:CONFIG_ARGS=  '--prefix=/nix/store/y78kh4c49qz3m8al5mmxqxanncfs4x0h-python3-3.7.1' '--enable-shared' '--with-threads' '--without-ensurepip' '--with-system-expat' '--with-system-ffi' '--with-openssl=/nix/store/w70ksa7qjl493p30gnwl03jkambn2gcn-openssl-1.0.2p-dev' 'CC=gcc' 'LDFLAGS=         ' 'LIBS=-lcrypt -lncurses' 'CPPFLAGS=

which seems safe to nuke.

The _sysconfig_data module is similar, with stuff like

 'CONFIG_ARGS': "'--prefix=/nix/store/y78kh4c49qz3m8al5mmxqxanncfs4x0h-python3-3.7.1' "
                "'--enable-shared' '--with-threads' '--without-ensurepip' "
                "'--with-system-expat' '--with-system-ffi' "
                "'--with-openssl=/nix/store/w70ksa7qjl493p30gnwl03jkambn2gcn-openssl-1.0.2p-dev' "

but it also contains stuff pertaining to the python install which maybe shouldn't be nuked, such as

 'CONFINCLUDEDIR': '/nix/store/y78kh4c49qz3m8al5mmxqxanncfs4x0h-python3-3.7.1/include',
 'BINDIR': '/nix/store/y78kh4c49qz3m8al5mmxqxanncfs4x0h-python3-3.7.1/bin',

Then again I'm not too familiar with how this stuff is actually being used elsewhere.

@dotlambda
Copy link
Member

conflicts with #51775

@FRidh
Copy link
Member Author

FRidh commented Dec 26, 2018

Pushed 2526f9f to staging.

@FRidh FRidh closed this Dec 26, 2018
@FRidh FRidh deleted the python37 branch December 26, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants