-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyqt5: make qtwebkit optional, disable by default #51846
Commits on Dec 27, 2018
-
Since about 5 hydra evaluations ago the build log has: substituteStream(): WARNING: pattern 'install_dir=pydbusmoddir' doesn't match anything in file 'configure.py' substituteStream(): WARNING: pattern 'ModuleMetadata(qmake_QT=['webkitwidgets'])' doesn't match anything in file 'configure.py' Looking at the original configure.py I don't see any mention of pydbusmoddir and ModuleMetadata seems to be set like the patch suggests: 'QtWebKitWidgets': ModuleMetadata( qmake_QT=['webkitwidgets', 'printsupport']), It appears that we don't need the fix anymore. Reverts: d3ed0ab ('PyQt: fix build')
Configuration menu - View commit details
-
Copy full SHA for 9b07d48 - Browse repository at this point
Copy the full SHA 9b07d48View commit details -
pyqt5: make qtwebkit optional, disable by default
qtwebkit appears to be unsupported in Qt 5.11. We are using some old port https://github.com/NixOS/nixpkgs/blob/475d653afdbd8fe3e00ccfd22a30014b0df7aeaa/pkgs/development/libraries/qt-5/5.11/default.nix#L39-L48 and it is broken on darwin.
Configuration menu - View commit details
-
Copy full SHA for facefec - Browse repository at this point
Copy the full SHA facefecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c19829 - Browse repository at this point
Copy the full SHA 3c19829View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20d60c8 - Browse repository at this point
Copy the full SHA 20d60c8View commit details -
pythonPackages.qtconsole: build on darwin
Fixes: d7ef9a7 ('python36Packages.qtconsole: 4.4.2 -> 4.4.3')
Configuration menu - View commit details
-
Copy full SHA for 97ec7a9 - Browse repository at this point
Copy the full SHA 97ec7a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07a6736 - Browse repository at this point
Copy the full SHA 07a6736View commit details -
qutebrowser: drop QtWebKit support
From the qutebrowser README: "support for QtWebKit will be dropped soon"
Configuration menu - View commit details
-
Copy full SHA for 8df467e - Browse repository at this point
Copy the full SHA 8df467eView commit details
Commits on Dec 30, 2018
-
electron-cash: doesn't need QtWebKit
Upstream issue: Electron-Cash/Electron-Cash#1078
Configuration menu - View commit details
-
Copy full SHA for ae87977 - Browse repository at this point
Copy the full SHA ae87977View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16f11df - Browse repository at this point
Copy the full SHA 16f11dfView commit details -
git-cola: doesn't need QtWebKit
QtWebKit is only used if QtWebEngine is not available
Configuration menu - View commit details
-
Copy full SHA for eecc336 - Browse repository at this point
Copy the full SHA eecc336View commit details