Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: use python37 #51914

Merged
merged 2 commits into from Dec 19, 2018
Merged

Conversation

dotlambda
Copy link
Member

Home Assistant builds with python37 now. However, hbmqtt does not until 494f969 lands in master. We should not merge until that happens.

Motivation for this change

Reduce the load on Hydra.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Robert Schütz added 2 commits December 12, 2018 16:44
The dependency was removed in version 0.14.9.
This reverts commit 2fb90e5.
Home Assistant now builds fine with Python 3.7.
@Mic92 Mic92 changed the title home-assistant: use python37 [WIP] home-assistant: use python37 Dec 12, 2018
@peterhoeg
Copy link
Member

I'll give this a go on the weekend. As I'm using mosquitto, the hbmqtt constraint isn't an issue.

@dotlambda
Copy link
Member Author

Can this be merged?

@dotlambda dotlambda changed the title [WIP] home-assistant: use python37 home-assistant: use python37 Dec 19, 2018
@fpletz fpletz merged commit 65dfc2b into NixOS:master Dec 19, 2018
@dotlambda dotlambda deleted the home-assistant-python37 branch March 21, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants