Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager: 1.12.2 -> 1.12.6 #52574

Closed
wants to merge 2 commits into from
Closed

networkmanager: 1.12.2 -> 1.12.6 #52574

wants to merge 2 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 20, 2018

Motivation for this change

Contains cups build fix (which is a separate PR),
so that this can be built and such.

More conservative than upgrade to 1.14.x as done in
#51122 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
cups: drop patches
ec040d9 
(cherry picked from commit 085a74c)
@dtzWill
network-manager: 1.12.2 -> 1.12.6
27e6de9 
https://github.com/NetworkManager/NetworkManager/blob/1.12.6/NEWS

Notably fixes CVE-2018-15688, although I don't believe we use
the internal dhcp client by default.
@dtzWill
Copy link
Member Author

dtzWill commented Dec 20, 2018

Depending on taste might want to pick this as a cleanup: 85cd0a0

@worldofpeace worldofpeace mentioned this pull request Dec 22, 2018
Merged
10 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Dec 22, 2018

Closing in favor of #51122 ! :)

@dtzWill dtzWill closed this Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: printing 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg