Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/prometheus-bind-exporter: add module #52726

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

eonpatapon
Copy link
Contributor

Motivation for this change
Things done

nix-build nixos/tests/prometheus-exporters.nix

But tor exporter test is failing.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eonpatapon
Copy link
Contributor Author

@GrahamcOfBorg test prometheus-exporters

@Mic92
Copy link
Member

Mic92 commented Dec 23, 2018

@GrahamcOfBorg build nixosTests.prometheus-exporters.bind

@eonpatapon
Copy link
Contributor Author

@GrahamcOfBorg build nixosTests.prometheus-exporters

@eonpatapon
Copy link
Contributor Author

@GrahamcOfBorg build nixosTests.prometheus-exporters.bind

There is only one test that spawns one VM per exporter to test :/

@infinisil
Copy link
Member

Yeah just hardcode the pid file in that case. I doubt anybody would ever want to change the location of it.

@eonpatapon
Copy link
Contributor Author

Done

@globin globin merged commit 4f99f8d into NixOS:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants