Skip to content

electron: 3.0.5 -> 4.0.0 #52770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

electron: 3.0.5 -> 4.0.0 #52770

merged 1 commit into from
Jan 4, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Dec 24, 2018

Motivation for this change

Include libuuid for libuuid.so.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 24, 2018
jtojnar
jtojnar reviewed Dec 24, 2018
View reviewed changes
@eadwu eadwu force-pushed the electron/4.0.0 branch 2 times, most recently from 117c9e5 to 544edc7 Compare December 24, 2018 15:56
@joachifm
Copy link
Contributor

joachifm commented Jan 2, 2019

@GrahamcOfBorg build electron

@joachifm joachifm merged commit f0e28f9 into NixOS:master Jan 4, 2019
@eadwu eadwu deleted the electron/4.0.0 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eadwu @joachifm @jtojnar @GrahamcOfBorg