Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

way-cooler: 0.8.0 -> 0.8.1 #53220

Merged
merged 2 commits into from Jan 15, 2019
Merged

way-cooler: 0.8.0 -> 0.8.1 #53220

merged 2 commits into from Jan 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 2, 2019

Motivation for this change

Closes #50847

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from infinisil as a code owner January 2, 2019 17:58
@ghost
Copy link
Author

ghost commented Jan 2, 2019

@P-E-Meunier I've regenerated only way-cooler derivation using recent carnix, components (wc-bg, wc-lock, wc-grab) are left untouched, because I don't know how to merge crates-io.nix files altogether https://nest.pijul.org/pmeunier/carnix/discussions/23 And using an own crates-io.nix file for each component is not good for me.

@ghost ghost mentioned this pull request Jan 7, 2019
Closed
@dywedir
Copy link
Member

dywedir commented Jan 14, 2019

@GrahamcOfBorg build way-cooler

@dywedir
Copy link
Member

dywedir commented Jan 14, 2019

Please mark as broken on aarch64

@ghost
Copy link
Author

ghost commented Jan 15, 2019

@dywedir Done.

@dywedir
Copy link
Member

dywedir commented Jan 15, 2019

@GrahamcOfBorg build way-cooler

@dywedir dywedir merged commit 30ff54c into NixOS:master Jan 15, 2019
@ghost
Copy link
Author

ghost commented Jan 16, 2019

@dywedir Thanks!

@ghost ghost deleted the way-cooler branch January 16, 2019 05:08
@dywedir
Copy link
Member

dywedir commented Jan 16, 2019

@gnidorah thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dywedir @GrahamcOfBorg