Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omping: init at 0.0.5 #53498

Merged
merged 1 commit into from
Jan 10, 2019
Merged

omping: init at 0.0.5 #53498

merged 1 commit into from
Jan 10, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Missing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.


postPatch = ''
substituteInPlace Makefile \
--replace /usr/local $out \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use makeFlags = [ "PREFIX=${placeholder "out"}" ];

postPatch = ''
substituteInPlace Makefile \
--replace /usr/local $out \
--replace '$<.8' '$(EXEC).8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterhoeg
Copy link
Member Author

Good points @jtojnar - fixed.

@dywedir dywedir merged commit 8336cca into NixOS:master Jan 10, 2019
@peterhoeg peterhoeg deleted the p/omping branch January 11, 2019 06:10
@peterhoeg peterhoeg restored the p/omping branch January 11, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants