New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omping: init at 0.0.5 #53498

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
4 participants
@peterhoeg
Copy link
Member

peterhoeg commented Jan 6, 2019

Motivation for this change

Missing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg force-pushed the peterhoeg:p/omping branch from 2ec270e to b63fd77 Jan 7, 2019


postPatch = ''
substituteInPlace Makefile \
--replace /usr/local $out \

This comment has been minimized.

@jtojnar

jtojnar Jan 7, 2019

Contributor

You can use makeFlags = [ "PREFIX=${placeholder "out"}" ];

postPatch = ''
substituteInPlace Makefile \
--replace /usr/local $out \
--replace '$<.8' '$(EXEC).8'

This comment has been minimized.

@jtojnar

@peterhoeg peterhoeg force-pushed the peterhoeg:p/omping branch from b63fd77 to 4e053fe Jan 8, 2019

@peterhoeg

This comment has been minimized.

Copy link
Member Author

peterhoeg commented Jan 8, 2019

Good points @jtojnar - fixed.

@jtojnar

jtojnar approved these changes Jan 8, 2019

@dywedir dywedir merged commit 8336cca into NixOS:master Jan 10, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@peterhoeg peterhoeg deleted the peterhoeg:p/omping branch Jan 11, 2019

@peterhoeg peterhoeg restored the peterhoeg:p/omping branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment