Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radare2: add propagated build inputs #53667

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 8, 2019

Motivation for this change

Fixes the cutter build which was broken when radare2 was moved away from
vendored dependencies in #51837.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes the cutter build which was broken when radare2 was moved away from
vendored dependencies in NixOS#51837.
@timokau
Copy link
Member Author

timokau commented Jan 8, 2019

@GrahamcOfBorg build radare2-cutter

@timokau
Copy link
Member Author

timokau commented Jan 8, 2019

I meant #51831, not #51837.

@timokau timokau mentioned this pull request Jan 8, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants