Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pygal: fix build #53833

Merged
merged 1 commit into from Jan 12, 2019
Merged

python.pkgs.pygal: fix build #53833

merged 1 commit into from Jan 12, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 12, 2019 •
edited

Motivation for this change

Missing build input.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner January 12, 2019 10:45
@timokau
Copy link
Member Author

timokau commented Jan 12, 2019

@GrahamcOfBorg build python2.pkgs.pygal python3.pkgs.pygal

worldofpeace
worldofpeace reviewed Jan 12, 2019
View reviewed changes
pkgs/development/python-modules/pygal/default.nix
pyquery

# Should be a check input, but upstream lists it under "setup_requires".
# https://github.com/Kozea/pygal/issues/430
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably just do like

nixpkgs/pkgs/development/python-modules/pyrsistent/default.nix

Line 24 in 1b1ea35

patches = [ ./no-setup-requires-pytestrunner.patch ];

Though I probably should have upstreamed that one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its worth maintaining a patch here. Is there any downside to just listing it in buildInputs? Its not propagated.

@timokau
python.pkgs.pygal: fix build
c0eb99f 
`pytestrunner` is a required build input.

Also we need to explicitly set the locale to pass the tests on darwin.
@timokau
Copy link
Member Author

timokau commented Jan 12, 2019

Trying some ofBorg driven darwin debugging...
@GrahamcOfBorg build python3.pkgs.pygal

@timokau timokau merged commit b54d9e2 into NixOS:master Jan 12, 2019
@timokau timokau deleted the pygal-fix branch January 12, 2019 14:08
voobscout pushed a commit to voobscout/nixpkgs that referenced this pull request Jan 16, 2019
@timokau @voobscout
python.pkgs.pygal: fix build (NixOS#53833)
ccd1468 
`pytestrunner` is a required build input.

Also we need to explicitly set the locale to pass the tests on darwin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @worldofpeace @GrahamcOfBorg