Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssh: apply CVE-2018-20685 patch #53896

Merged
merged 1 commit into from Jan 13, 2019
Merged

openssh: apply CVE-2018-20685 patch #53896

merged 1 commit into from Jan 13, 2019

Conversation

andir
Copy link
Member

@andir andir commented Jan 13, 2019

Motivation for this change

@samueldr mentioned in #nixos-security (IRC) that there exists an issue with SCP (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919101; variant 1 from https://sintonen.fi/advisories/scp-client-multiple-vulnerabilities.txt).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member Author

andir commented Jan 13, 2019

@GrahamcOfBorg test openssh
@GrahamcOfBorg build openssh openssh_hpn openssh_gssapi

@samueldr
Copy link
Member

Relevant discussion mentioned in the PR

@vcunat
Copy link
Member

vcunat commented Jan 13, 2019

The rebuild amount sounds OK for a security fix – < 6k for all platforms together.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests succeeded for me locally (x86_64-linux) and on aarch64.nixos.community.

@andir
Copy link
Member Author

andir commented Jan 13, 2019

Thanks for reviewing!

@andir andir merged commit 2013d86 into NixOS:master Jan 13, 2019
@andir andir deleted the openssh branch January 13, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants