Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getdns: 1.5.0 -> 1.5.1, stubby: 0.2.4 -> 0.2.5 #53916

Merged
merged 1 commit into from Jan 27, 2019
Merged

getdns: 1.5.0 -> 1.5.1, stubby: 0.2.4 -> 0.2.5 #53916

merged 1 commit into from Jan 27, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 13, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Moredread
Moredread approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@Moredread Moredread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine :)

Checked with nix-review on a nixos-18.09 system. Have executed the binaries but not checked their functionality.

@Mic92
Copy link
Member

Mic92 commented Jan 14, 2019

cc @baroncharlus for testing the stubby module.

@Mic92 Mic92 mentioned this pull request Jan 16, 2019
Closed
@dtzWill dtzWill merged commit 2b01084 into NixOS:master Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moredread Moredread Moredread approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @Mic92 @Moredread @GrahamcOfBorg