Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

programs/nano: Generate nanorc if syntaxHighlight enabled #53968

Merged
merged 1 commit into from Jan 14, 2019

Conversation

avdv
Copy link
Member

@avdv avdv commented Jan 14, 2019

  • prepend a newline to the include directive
  • generate the nanorc by default, since cfg.syntaxHighlight is true
Motivation for this change

As a beginner with NixOS I was struggling how to enable syntax highlighting for nano, given that by default it should be already enabled.

To actually get it enabled one has to change the value of config.programs.nano.nanorc to a value different from the empty string.

I did, but it did not work at first, since one has to remember to add a newline to the value since it simply gets concatenated to the include "${pkgs.nano}/share/nano/*.nanorc" config statement.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@avdv avdv requested a review from infinisil as a code owner January 14, 2019 22:12
* prepend a newline to the `include` directive
* generate the nanorc by default, since `cfg.syntaxHighlight` is `true`
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a VM locally, this fixes the syntax highlighting option for nano 👍

@Ma27
Copy link
Member

Ma27 commented Jan 14, 2019

@avdv thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants