Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.phpstan: init at 0.11 #54171

Merged
merged 1 commit into from Jan 17, 2019
Merged

phpPackages.phpstan: init at 0.11 #54171

merged 1 commit into from Jan 17, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Jan 17, 2019 •
edited

Motivation for this change

PHP Static Analysis Tool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
phpPackages.phpstan: init at 0.11
d580b66 
PHP Static Analysis Tool
@etu
Copy link
Contributor Author

etu commented Jan 17, 2019

@GrahamcOfBorg build phpPackages.phpstan php71Packages.phpstan php72Packages.phpstan php73Packages.phpstan

@jtojnar
Copy link
Contributor

jtojnar commented Jan 17, 2019

Thanks.

@jtojnar jtojnar merged commit 6bd544d into NixOS:master Jan 17, 2019
@etu etu deleted the init-phpstan branch January 17, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @jtojnar @GrahamcOfBorg