Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xorg.luit: fix darwin build #54481

merged 1 commit into from Jan 28, 2019

xorg.luit: fix darwin build #54481

merged 1 commit into from Jan 28, 2019


Copy link

@LnL7 LnL7 commented Jan 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Copy link

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generated file. Please, edit overrides.nix instead.

Copy link
Member Author

LnL7 commented Jan 22, 2019

I had a feeling that was the case, should have checked.

@LnL7 LnL7 merged commit edcc3e5 into NixOS:master Jan 28, 2019
@LnL7 LnL7 deleted the darwin-luit branch January 28, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants