-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/pulseaudio: disable flat-volumes by default #54622
nixos/pulseaudio: disable flat-volumes by default #54622
Conversation
I think this warrants a release notes entry mentioning what this effectively changes to volumes. If I read correctly,
Somebody correct me if I'm wrong. |
Disabling flat volumes enables relative volumes, apt to being relative to an absolute master volume.
Its effect is that we don't torture people anymore 🤣 See: https://youtu.be/Skl1Gf8RCCw?t=54I'll write a pretty terse one. |
For anyone unclear on volume model sitiuation, this comment could be helpful to read. |
The motivation for this is that some applications are unaware of this feature and can set their volume to 100% on startup harming people ears and possiblly blowing someone's audio setup. I noticed this in NixOS#54594 and by extension epiphany[0]. Please also note that many other distros have this default for the reason outlined above. Closes NixOS#5632 NixOS#54594 [0]: https://bugzilla.gnome.org/show_bug.cgi?id=675217
89a3f2f
to
fdbe243
Compare
Did the thing @infinisil. |
I think I'm going to merge this right away because the conclusion to do this has been already reached several times in other places. So we really don't need comuntity feedback for a solution that's already substantiated. |
Motivation for this change
Some applications are unaware of this feature and can set their volume to 100% on startup harming people ears and possiblly blowing someone's audio setup.
I noticed this in #54594 and by extension epiphany.
Please also note that many other distros have this default for the reason outlined above.
Closes #5632 #54594
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)