-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cc-wrapper: add libcxx for libcxxClang #54624
Conversation
4eebb31
to
ce17f99
Compare
clang needs to find headers + libraries for compiling with libc++. We need to add a libcxx argument to cc-wrapper. This means you do not have to pass in c++ headers directly. This resolves the last case remaining of NixOS#30670. Darwin clang++ now works properly. Fixes NixOS#30670
Is this Darwin-only? We previously had tests for this--were they failing? They seem to pass for me in my tree, FWIW. I use (regardless, is there a particular usage/scenario fixed by this? And should that be a test to ensure this works in the future?) |
This makes clang++ work outside of a Nix derivation... It's a kind of specific use case but was often an issue. We provide it for g++, so we might as well make it work with clang. |
I completely agree, why does this not work on NixOS systems as well? I love NixOS but it's times like this that I get really frustrated with it... I'm not always in the mood to write up a whole JFC I'm not criticizing the author, I'm asking why this behavior is only for Darwin? |
It might be better since f3f7612 |
|
clang needs to find headers + libraries for compiling with libc++. We
need to add a libcxx argument to cc-wrapper. This means you do not
have to pass in c++ headers directly.
This resolves the last case remaining of #30670. Darwin clang++ now
works properly.
Fixes #30670