mautrix-telegram: init at 0.4.0.post1 #54893
Conversation
|
|
||
| let | ||
|
|
||
| localPython = python3.override { |
There was a problem hiding this comment.
Can't do that for python packages. However, isn't this an application rather than a library?
There was a problem hiding this comment.
It's both, because an other tool need to import it to work. What would be suggested to force the dependency version ?
There was a problem hiding this comment.
What would be suggested to force the dependency version ?
There is none as long as this is in pythonPackages. The suggested way to deal with this is to make an upstream PR that fixes it.
There was a problem hiding this comment.
As you see in mautrix/telegram@a258c59, their pinning of telethon is completely useless. Just apply that patch to make it work.
There was a problem hiding this comment.
an other tool need to import it to work
Would you mind adding that tool to this PR or at least giving me a link?
There was a problem hiding this comment.
the manual is suggesting that this is the preferred method when a python library is also a application
I'd say it's not actually a library, just a strange requirement of using alembic.
What's your stance @worldofpeace?
There was a problem hiding this comment.
the manual is suggesting that this is the preferred method when a python library is also a application
I'd say it's not actually a library, just a strange requirement of using alembic.
What's your stance @worldofpeace?
I agree that this is an application and belongs in all-packages.nix and alembic just has this requirement.
There was a problem hiding this comment.
If you ever need to use it with alembic you can use pkgs.python3.withPackages (ps: [ ps.alembic (ps.toPythonModule pkgs.mautrix-telegram) ]).
So they'd have to do that to setup the bridge.
There was a problem hiding this comment.
I think it's only used for updating the database scheme.
There was a problem hiding this comment.
I think it should be ok now
nyanloutre
force-pushed
the
mautrix-telegram
branch
5 times, most recently
from
ddf463b
to
1c2fe30
Compare
nyanloutre
force-pushed
the
mautrix-telegram
branch
from
1c2fe30
to
00e14ce
Compare
nyanloutre
force-pushed
the
mautrix-telegram
branch
2 times, most recently
from
ec0db1b
to
4484a69
Compare
nyanloutre
force-pushed
the
mautrix-telegram
branch
from
4484a69
to
53fddad
Compare
|
@GrahamcOfBorg build mautrix-telegram |
|
Seems like we forgot something: 6d19c1d |
|
and 467df7b |
Motivation for this change
Bridge library between Matrix and Telegram
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)