Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mautrix-telegram: init at 0.4.0.post1 #54893

Merged
merged 5 commits into from Jan 31, 2019

Conversation

@nyanloutre
Copy link
Contributor

commented Jan 29, 2019

Motivation for this change

Bridge library between Matrix and Telegram

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Show resolved Hide resolved pkgs/development/python-modules/future-fstrings/default.nix
Show resolved Hide resolved pkgs/development/python-modules/future-fstrings/default.nix
Show resolved Hide resolved pkgs/development/python-modules/mautrix-appservice/default.nix
Show resolved Hide resolved pkgs/development/python-modules/mautrix-telegram/default.nix Outdated

let

localPython = python3.override {

This comment has been minimized.

Copy link
@dotlambda

dotlambda Jan 29, 2019

Member

Can't do that for python packages. However, isn't this an application rather than a library?

This comment has been minimized.

Copy link
@nyanloutre

nyanloutre Jan 29, 2019

Author Contributor

It's both, because an other tool need to import it to work. What would be suggested to force the dependency version ?

This comment has been minimized.

Copy link
@dotlambda

dotlambda Jan 30, 2019

Member

What would be suggested to force the dependency version ?

There is none as long as this is in pythonPackages. The suggested way to deal with this is to make an upstream PR that fixes it.

This comment has been minimized.

Copy link
@dotlambda

dotlambda Jan 30, 2019

Member

As you see in tulir/mautrix-telegram@a258c59, their pinning of telethon is completely useless. Just apply that patch to make it work.

This comment has been minimized.

Copy link
@dotlambda

dotlambda Jan 30, 2019

Member

an other tool need to import it to work

Would you mind adding that tool to this PR or at least giving me a link?

This comment has been minimized.

Copy link
@dotlambda

dotlambda Jan 30, 2019

Member

the manual is suggesting that this is the preferred method when a python library is also a application

I'd say it's not actually a library, just a strange requirement of using alembic.
What's your stance @worldofpeace?

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Jan 30, 2019

Member

the manual is suggesting that this is the preferred method when a python library is also a application

I'd say it's not actually a library, just a strange requirement of using alembic.
What's your stance @worldofpeace?

I agree that this is an application and belongs in all-packages.nix and alembic just has this requirement.

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Jan 30, 2019

Member

If you ever need to use it with alembic you can use pkgs.python3.withPackages (ps: [ ps.alembic (ps.toPythonModule pkgs.mautrix-telegram) ]).

So they'd have to do that to setup the bridge.

This comment has been minimized.

Copy link
@dotlambda

dotlambda Jan 30, 2019

Member

I think it's only used for updating the database scheme.

This comment has been minimized.

Copy link
@nyanloutre

nyanloutre Jan 31, 2019

Author Contributor

I think it should be ok now

Show resolved Hide resolved pkgs/development/python-modules/telethon-session-sqlalchemy/default.nix
Show resolved Hide resolved pkgs/development/python-modules/future-fstrings/default.nix Outdated
Show resolved Hide resolved pkgs/development/python-modules/telethon/default.nix
Show resolved Hide resolved pkgs/development/python-modules/telethon/default.nix

@nyanloutre nyanloutre force-pushed the nyanloutre:mautrix-telegram branch 5 times, most recently from ddf463b to 1c2fe30 Jan 29, 2019

@nyanloutre nyanloutre force-pushed the nyanloutre:mautrix-telegram branch from 1c2fe30 to 00e14ce Jan 30, 2019

@nyanloutre nyanloutre force-pushed the nyanloutre:mautrix-telegram branch 2 times, most recently from ec0db1b to 4484a69 Jan 30, 2019

@dotlambda dotlambda changed the title Mautrix telegram mautrix-telegram: init at 0.4.0.post1 Jan 30, 2019

@nyanloutre nyanloutre force-pushed the nyanloutre:mautrix-telegram branch from 4484a69 to 53fddad Jan 31, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

@GrahamcOfBorg build mautrix-telegram

@dotlambda dotlambda merged commit 864f832 into NixOS:master Jan 31, 2019

13 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mautrix-telegram on aarch64-linux Success
Details
mautrix-telegram on x86_64-darwin Success
Details
mautrix-telegram on x86_64-linux Success
Details

@nyanloutre nyanloutre deleted the nyanloutre:mautrix-telegram branch Jan 31, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Seems like we forgot something: 6d19c1d

@dotlambda

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

and 467df7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.