chromium: 71.0.3578.98 -> 72.0.3626.81

[ivan]

Motivation for this change

https://chromereleases.googleblog.com/2019/01/stable-channel-update-for-desktop.html

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

The updated chromium is working fine here, I did not test chromiumDev.

[dtzWill]

Finally a stable update! \o/

[ivan]

Do not merge, I am not hearing any sound output with ALSA in Chromium 72:

ALSA lib conf.c:3943:(snd_config_update_r) Cannot access file /nix/store/z6xww8cyf59sld729qinzh6ji51kq6ap-alsa-lib-1.1.7/share/alsa/alsa.conf
ALSA lib conf.c:3943:(snd_config_update_r) Cannot access file /nix/store/z6xww8cyf59sld729qinzh6ji51kq6ap-alsa-lib-1.1.7/share/alsa/alsa.conf
[...]
ALSA lib conf.c:3943:(snd_config_update_r) Cannot access file /nix/store/z6xww8cyf59sld729qinzh6ji51kq6ap-alsa-lib-1.1.7/share/alsa/alsa.conf
ALSA lib pcm.c:2636:(snd_pcm_open_noupdate) Unknown PCM default
ALSA lib conf.c:3943:(snd_config_update_r) Cannot access file /nix/store/z6xww8cyf59sld729qinzh6ji51kq6ap-alsa-lib-1.1.7/share/alsa/alsa.conf
ALSA lib pcm.c:2636:(snd_pcm_open_noupdate) Unknown PCM plug:default

71 works fine.

[ivan]

https://chromium.googlesource.com/chromium/src/+/f2fc90bb74a05cffde6b4363ee575fcca7c45197

https://github.com/chromium/chromium/blob/master/services/audio/audio_sandbox_hook_linux.cc might need to be patched

I am currently testing

diff --git a/pkgs/applications/networking/browsers/chromium/common.nix b/pkgs/applications/networking/browsers/chromium/common.nix
index 5af8fa60cec..1748387787c 100644
--- a/pkgs/applications/networking/browsers/chromium/common.nix
+++ b/pkgs/applications/networking/browsers/chromium/common.nix
@@ -12,6 +12,7 @@
 , utillinux, alsaLib
 , bison, gperf
 , glib, gtk2, gtk3, dbus-glib
+, glibc
 , libXScrnSaver, libXcursor, libXtst, libGLU_combined
 , protobuf, speechd, libXdamage, cups
 , ffmpeg, libxslt, libxml2, at-spi2-core
@@ -169,6 +170,17 @@ let
           'return sandbox_binary;' \
           'return base::FilePath(GetDevelSandboxPath());'

+      substituteInPlace services/audio/audio_sandbox_hook_linux.cc \
+        --replace \
+          '/usr/share/alsa/' \
+          '${alsaLib}/share/alsa/' \
+        --replace \
+          '/usr/lib/x86_64-linux-gnu/gconv/' \
+          '${glibc}/lib/gconv/' \
+        --replace \
+          '/usr/share/locale/' \
+          '${glibc}/share/locale/'
+
       sed -i -e 's@"\(#!\)\?.*xdg-@"\1${xdg_utils}/bin/xdg-@' \
         chrome/browser/shell_integration_linux.cc

[dtzWill]

6b27008 FWIW

[ivan]

I added a new commit to make audio output work again with ALSA, @bendlas want to cherry-pick 33375dc to master or should I make a new PR? no need I guess, since no conflicts

[ivan]

Also, I haven't tested with pulseaudio, if someone uses it, please test.

[pbogdan]

FWIW tested with master @ 6b27008 and 33375dc cherry-picked on top and sound output works for me with pulseaudio.

[bendlas]

Oh, I didn't even check for a PR, before updating chromium, sorry. I'll pick your change as soon as I get home.