-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
papis: 0.6 -> 0.7.5 #55009
papis: 0.6 -> 0.7.5 #55009
Conversation
LGTM! And upstream merged your dateparser fixes so we can use 3.7 again once there's a release or we pick the changes or w/e (sounds like you've got it under control ❤️). Haha I apparently have a small set of documents from looking into this last time 'round xD. |
pname = "filetype"; | ||
version = "1.0.2"; | ||
|
||
src = fetchFromGitHub { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while I personnally have no complaint with this, I am often asked when upstreaming packages why I didn't use fetchPypi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I forgot to add a comment.
{ lib, fetchFromGitHub, bashInteractive | ||
, python3, vim | ||
{ lib, fetchFromGitHub, fetchpatch | ||
, python36, xdg_utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's cleaner to pass buildPythonApplication here and do papis = python36Packages.callPackage ../tools/misc/papis { }; in all-packages.nix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's discouraged because it doesn't allow the overriding of Python packages for specific applications.
Would be cool to get the bash autocompletion too. According to doc/source/shell_completion.rst, pip generates one in /usr/local/etc/bash_completion.d/papis |
I've tested things a bit and browse / export /add work.. Thanks for the great work ! Looking forward to this. |
dateparser tests fail on python37: NixOS#52766
0e28815
to
07664bc
Compare
Done. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)cc @teto @dtzWill @nico202