corretto8: init at 8.202.08.2 #55156
Conversation
andrew-d
force-pushed
the
andrew/corretto
branch
2 times, most recently
from
d5957c6 to
01bb432
Compare
GrahamcOfBorg
added
8.has: package (new)
|
|
||
| # Some minor patches to OpenJDK to get everything building; taken from: | ||
| # https://github.com/corretto/corretto-8/issues/23 | ||
| ./corretto.patch |
There was a problem hiding this comment.
Is it possible to fetch rather than add the patch to the repo?
There was a problem hiding this comment.
The actual patch isn't a PR on the main repository, but rather a commit from a fork:
dacut/corretto-8@68c43e7
(EDIT: especially since the patch is so small)
I thought that committing the patch would be more resilient to the fork being deleted or changed, but happy to fetchpatch that diff if you'd rather.
There was a problem hiding this comment.
By itself this is benign, I guess, but it still adds to the overall amount of unnecessary stuff in the repo. Your call.
There was a problem hiding this comment.
(Source files are normally mirrored by the nixos org, can't say whether patch files are without checking the script)
There was a problem hiding this comment.
I think I'll keep it; if it was more than 2 lines, I'd fetch it, but as-is I think it's pretty small.
andrew-d
force-pushed
the
andrew/corretto
branch
from
01bb432 to
9b3b96e
Compare
| , bash | ||
| , openjdk8 | ||
|
|
||
| , ... |
There was a problem hiding this comment.
Nit: Without args I think it makes sense to remove the rest capture as well
There was a problem hiding this comment.
Yep, also fair - done! 👍
andrew-d
force-pushed
the
andrew/corretto
branch
from
9b3b96e to
e8247a7
Compare
| @@ -7196,6 +7196,11 @@ in | |||
| licenseAccepted = config.oraclejdk.accept_license or false; | |||
| }); | |||
|
|
|||
| corretto8 = callPackage ../development/compilers/openjdk/corretto.nix { | |||
| bootjdk = bootjdk.override { version = "8"; }; | |||
| inherit (gnome2) GConf gnome_vfs; | |||
There was a problem hiding this comment.
Eval error here. I guess these used to be captured by args
andrew-d
force-pushed
the
andrew/corretto
branch
from
e8247a7 to
75d14a3
Compare
andrew-d
force-pushed
the
andrew/corretto
branch
from
75d14a3 to
51b8fa8
Compare
|
@andrew-d What is the status of this? |
ryantm
added
the
2.status: merge conflict
Motivation for this change
AWS Corretto is a distribution of OpenJDK that comes with additional performance and security patches, and long-term support until at least June 2023.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)As maintainers of the existing OpenJDK 8 package:
r? @edwtjo @NeQuissimus
I'd be interested to hear what you folks think about this "override
openjdk8" approach; it saves a ton of code duplication and refactoring compared to writing an entirely new derivation.