Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranger: add pillow dependency #55270

Merged
merged 1 commit into from Feb 5, 2019
Merged

ranger: add pillow dependency #55270

merged 1 commit into from Feb 5, 2019

Conversation

jlesquembre
Copy link
Member

Pillow is required to preview images with kitty terminal
To test it, add these 2 lines to your rc.conf:

set preview_images true
set preview_images_method kitty
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Pillow is required to display images with kitty terminal
To test it, add these 2 lines to your rc.conf:
set preview_images true
set preview_images_method kitty
@Ma27
Copy link
Member

Ma27 commented Feb 5, 2019

I'm sorry if I'm missing something, but image previews already work for me without your change in Kitty 0.11.3 and XTerm 335.

@jlesquembre
Copy link
Member Author

Maybe you have only set preview_images true but not set preview_images_method kitty?
In that case, ranger uses w3m, that works for me too (more or less, some images are not properly displayed)
If you want to use kitty directly to preview the images, pillow is required:
https://github.com/ranger/ranger/blob/ffee23a4d92a6f71cd62a6c763b13163e1bfae4a/doc/ranger.pod#kitty

On my tests, kitty does a better job that w3m

@Ma27
Copy link
Member

Ma27 commented Feb 5, 2019

You're right, I just screwed the local ranger config up, sorry :D

@Ma27 Ma27 merged commit 812d74c into NixOS:master Feb 5, 2019
@Ma27
Copy link
Member

Ma27 commented Feb 5, 2019

@jlesquembre thanks!

@jlesquembre jlesquembre deleted the ranger-images branch February 5, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants