-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zoom-us: don't set dontPatchELF #55566
Conversation
otherwise, autopatchelfHook seems to ignore patchelfing the zoom binary properly, causing it to fail to start: result/bin/zoom-us: line 4: /nix/store/7jfk4jggclvbwqxm9x4b4d57rr1mjh9q-zoom-us-2.7.162522.0121/share/zoom-us/zoom: No such file or directory
@flokli hm, why did it work before? |
@danbst I have no idea TBH… Didn't use it since last Wednesday, so it might have been something that changed since then - but I'm not too eager to bisect it down. Any idea why |
@flokli I don't know as well. @tadfisher any light on this topic? I've run
So, all patchelf do here is remove |
Let's merge this :-) |
Strange, I get the exact opposite. Zoom was working before, now I get:
I'm on It would be great to have some kind of executable tests integrated here. Does anyone know if there is any simple command to check the |
@kamilchm I think we can't run tests on Hydra, because this is proprietary stuff. Also, |
I'm on NixOS.
|
Interesting. I'm on 7ef9879 and here's what I have
Time to find source of impurity! |
@kamilchm can you also post your build log
? |
|
This must be the problem. I have:
Can you rebuild derivation, say, |
I tested you patch and zoom works for me now! Thx. |
This rare sitation was caught when building zoom-us package: ``` automatically fixing dependencies for ELF files /nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 213: echo: write error: Broken pipe /nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 210: echo: write error: Broken pipe ``` The worst is that derivation continued and resulted into broken package: NixOS#55566 (comment) I hope, replacing `grep -q` with `grep` will remove this race condition.
This rare sitation was caught when building zoom-us package: ``` automatically fixing dependencies for ELF files /nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 213: echo: write error: Broken pipe /nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 210: echo: write error: Broken pipe ``` The worst is that derivation continued and resulted into broken package: NixOS#55566 (comment) I hope, replacing `grep -q` with `grep` will remove this race condition.
otherwise, autopatchelfHook seems to ignore patchelfing the zoom binary
properly, causing it to fail to start:
cc @danbst
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)