Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom-us: don't set dontPatchELF #55566

Merged
merged 1 commit into from Feb 12, 2019
Merged

zoom-us: don't set dontPatchELF #55566

merged 1 commit into from Feb 12, 2019

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Feb 11, 2019

otherwise, autopatchelfHook seems to ignore patchelfing the zoom binary
properly, causing it to fail to start:

result/bin/zoom-us: line 4: /nix/store/7jfk4jggclvbwqxm9x4b4d57rr1mjh9q-zoom-us-2.7.162522.0121/share/zoom-us/zoom: No such file or directory

cc @danbst

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

otherwise, autopatchelfHook seems to ignore patchelfing the zoom binary
properly, causing it to fail to start:

result/bin/zoom-us: line 4: /nix/store/7jfk4jggclvbwqxm9x4b4d57rr1mjh9q-zoom-us-2.7.162522.0121/share/zoom-us/zoom: No such file or directory
@danbst
Copy link
Contributor

@danbst danbst commented Feb 11, 2019

@flokli hm, why did it work before?

@flokli
Copy link
Contributor Author

@flokli flokli commented Feb 11, 2019

@danbst I have no idea TBH… Didn't use it since last Wednesday, so it might have been something that changed since then - but I'm not too eager to bisect it down.

Any idea why dontPatchELF was set in first place? Is it only breaking some feature at runtime, or some leftovers?

@danbst
Copy link
Contributor

@danbst danbst commented Feb 11, 2019

@flokli I don't know as well. @tadfisher any light on this topic?

I've run diffoscope on build with and without this flag, and here is main difference

│ ├── zoom-us
│ │ ├── zoom
│ │ │ ├── readelf --wide --decompress --hex-dump=.dynstr {}
│ │ │ │ @@ -3803,16 +3803,16 @@
│ │ │ │    0x0040e3f0 6e64007a 4572726f 7200677a 74656c6c nd.zError.gztell
│ │ │ │    0x0040e400 36340067 7a636c6f 73655f77 00646566 64.gzclose_w.def
│ │ │ │    0x0040e410 6c617465 436f7079 00696e66 6c617465 lateCopy.inflate
│ │ │ │    0x0040e420 5072696d 6500677a 7365656b 00677a65 Prime.gzseek.gze
│ │ │ │    0x0040e430 72726f72 00676574 5f637263 5f746162 rror.get_crc_tab
│ │ │ │    0x0040e440 6c650067 7a676574 73005f65 64617461 le.gzgets._edata
│ │ │ │    0x0040e450 005f5f62 73735f73 74617274 005f656e .__bss_start._en
│ │ │ │ -  0x0040e460 64002f6f 70742f51 74352e39 2e362f35 d./opt/Qt5.9.6/5
│ │ │ │ -  0x0040e470 2e392e36 2f676363 5f36342f 6c696200 .9.6/gcc_64/lib.
│ │ │ │ +  0x0040e460 64000058 58585858 58585858 58585858 d..XXXXXXXXXXXXX
│ │ │ │ +  0x0040e470 58585858 58585858 58585858 58585800 XXXXXXXXXXXXXXX.
│ │ │ │    0x0040e480 5f5a4e31 34516d6c 4d656574 696e6749 _ZN14QmlMeetingI
│ │ │ │    0x0040e490 6e666f32 33736967 5f736c6f 774e5646 nfo23sig_slowNVF
│ │ │ │    0x0040e4a0 436f756e 74436861 6e676564 4576005f CountChangedEv._
│ │ │ │    0x0040e4b0 5a4e3131 4d657373 61676549 74656d31 ZN11MessageItem1
│ │ │ │    0x0040e4c0 37736967 5f617661 74617243 68616e67 7sig_avatarChang
│ │ │ │    0x0040e4d0 65644576 005f5a4e 31334665 61747572 edEv._ZN13Featur
│ │ │ │    0x0040e4e0 654f7074 696f6e32 35736967 5f6a6f69 eOption25sig_joi

So, all patchelf do here is remove /opt/Qt5.9.6/... ref. So, I don't understand how do you get your problem. It's more like you've removed the interpreter, or garbage collected it and trying to start some old checkout of Zoom...

@flokli
Copy link
Contributor Author

@flokli flokli commented Feb 12, 2019

Let's merge this :-)

@flokli flokli merged commit 6dc46f3 into NixOS:master Feb 12, 2019
13 checks passed
@flokli flokli deleted the zoom-us-fix branch Feb 12, 2019
@kamilchm
Copy link
Member

@kamilchm kamilchm commented Mar 6, 2019

Strange, I get the exact opposite. Zoom was working before, now I get:

/nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zoom: No such file or directory

I'm on 1233c8d9e9bc463899ed6a8cf0232e6bf36475ee from nixos-unstable.

It would be great to have some kind of executable tests integrated here. Does anyone know if there is any simple command to check the zoom-us executable from the command line?

@danbst
Copy link
Contributor

@danbst danbst commented Mar 6, 2019

@kamilchm I think we can't run tests on Hydra, because this is proprietary stuff.

Also, /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/bin/zoom-us works for me. What is your ldd /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zoom? Are you on Linux?

@kamilchm
Copy link
Member

@kamilchm kamilchm commented Mar 6, 2019

I'm on NixOS.

$ ldd /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zoom
	linux-vdso.so.1 (0x00007fff0a999000)
	libuuid.so.1 => not found
	libdl.so.2 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/libdl.so.2 (0x00007fc38b44f000)
	libX11.so.6 => not found
	librt.so.1 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/librt.so.1 (0x00007fc38b445000)
	libxcb.so.1 => not found
	libxcb-xfixes.so.0 => not found
	libxcb-shape.so.0 => not found
	libxcb-shm.so.0 => not found
	libxcb-randr.so.0 => not found
	libxcb-image.so.0 => not found
	libxcb-keysyms.so.1 => not found
	libxcb-xtest.so.0 => not found
	libXfixes.so.3 => not found
	libglib-2.0.so.0 => not found
	libdbus-1.so.3 => not found
	libQt5WebEngineWidgets.so.5 => not found
	libQt5WebEngineCore.so.5 => not found
	libQt5Quick.so.5 => not found
	libQt5PrintSupport.so.5 => not found
	libQt5Widgets.so.5 => not found
	libQt5Gui.so.5 => not found
	libQt5WebChannel.so.5 => not found
	libQt5Qml.so.5 => not found
	libQt5Network.so.5 => not found
	libQt5Script.so.5 => not found
	libQt5DBus.so.5 => not found
	libQt5Positioning.so.5 => not found
	libQt5Core.so.5 => not found
	libGL.so.1 => not found
	libpthread.so.0 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/libpthread.so.0 (0x00007fc38b41a000)
	libstdc++.so.6 => not found
	libm.so.6 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/libm.so.6 (0x00007fc38b284000)
	libc.so.6 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/libc.so.6 (0x00007fc38b0ce000)
	libgcc_s.so.1 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/libgcc_s.so.1 (0x00007fc38aeb8000)
	/lib64/ld-linux-x86-64.so.2 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib64/ld-linux-x86-64.so.2 (0x00007fc38b456000)

@danbst
Copy link
Contributor

@danbst danbst commented Mar 6, 2019

Interesting. I'm on 7ef9879 and here's what I have

$ ldd /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zoom
        linux-vdso.so.1 (0x00007ffd877f9000)
        libuuid.so.1 => /nix/store/qswxiwzbl80c4b3krhnifyglprg415zx-util-linux-2.33.1/lib/libuuid.so.1 (0x00007fdb73f05000)
        libdl.so.2 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/libdl.so.2 (0x00007fdb73efe000)
        libX11.so.6 => /nix/store/z6nlq8k2ba0cs0n2q8fqwzckjki2whrw-libX11-1.6.7/lib/libX11.so.6 (0x00007fdb73dbc000)
        librt.so.1 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/librt.so.1 (0x00007fdb73db2000)
        libxcb.so.1 => /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb.so.1 (0x00007fdb73d87000)
        libxcb-xfixes.so.0 => /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb-xfixes.so.0 (0x00007fdb73d7d000)
        libxcb-shape.so.0 => /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb-shape.so.0 (0x00007fdb73d77000)
        libxcb-shm.so.0 => /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb-shm.so.0 (0x00007fdb73d70000)
        libxcb-randr.so.0 => /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb-randr.so.0 (0x00007fdb73d5d000)
        libxcb-image.so.0 => /nix/store/5xwpvcaa46l2xzr9ahc7p9d0l33x2ybl-xcb-util-image-0.4.0/lib/libxcb-image.so.0 (0x00007fdb73d56000)
        libxcb-keysyms.so.1 => /nix/store/36jhcylqyfp0lpsm822hbxsj5g6lba2f-xcb-util-keysyms-0.4.0/lib/libxcb-keysyms.so.1 (0x00007fdb73d51000)
        libxcb-xtest.so.0 => /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb-xtest.so.0 (0x00007fdb73d4c000)
        libXfixes.so.3 => /nix/store/kf9q21bg2bryl03q8jqd8gl58fn0sfp4-libXfixes-5.0.3/lib/libXfixes.so.3 (0x00007fdb73d44000)
        libglib-2.0.so.0 => /nix/store/6i3zqxizaliin2j4ag7fh7adwywhmhch-glib-2.58.2/lib/libglib-2.0.so.0 (0x00007fdb73c01000)
        libdbus-1.so.3 => /nix/store/i8sjz5xjcihqwwm9232mz6fcj718jnyl-dbus-1.12.12-lib/lib/libdbus-1.so.3 (0x00007fdb73bad000)
        libQt5WebEngineWidgets.so.5 => /nix/store/rj8kdjc2digg548rvsi9n2llbpwrm4cl-qtwebengine-5.9.7/lib/libQt5WebEngineWidgets.so.5 (0x00007fdb73b67000)
        libQt5WebEngineCore.so.5 => /nix/store/rj8kdjc2digg548rvsi9n2llbpwrm4cl-qtwebengine-5.9.7/lib/libQt5WebEngineCore.so.5 (0x00007fdb6d1c6000)
        libQt5Quick.so.5 => /nix/store/y4sy7f4rxs2qyi9627xpj2f91hab18g1-qtdeclarative-5.9.7/lib/libQt5Quick.so.5 (0x00007fdb6cd72000)
        libQt5PrintSupport.so.5 => /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5PrintSupport.so.5 (0x00007fdb6ccff000)
        libQt5Widgets.so.5 => /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Widgets.so.5 (0x00007fdb6c6a6000)
        libQt5Gui.so.5 => /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Gui.so.5 (0x00007fdb6c13d000)
        libQt5WebChannel.so.5 => /nix/store/rqvx0f3g2cdlv066z1jqj1ys5qcgvxbj-qtwebchannel-5.9.7/lib/libQt5WebChannel.so.5 (0x00007fdb6c11c000)
        libQt5Qml.so.5 => /nix/store/y4sy7f4rxs2qyi9627xpj2f91hab18g1-qtdeclarative-5.9.7/lib/libQt5Qml.so.5 (0x00007fdb6bd15000)
        libQt5Network.so.5 => /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Network.so.5 (0x00007fdb6bb89000)
        libQt5Script.so.5 => /nix/store/qcxrirg55wsqlk2g269ajkzrn1y5z7av-zoom-us-qt-5.9.7/lib/libQt5Script.so.5 (0x00007fdb6b8f5000)
        libQt5DBus.so.5 => /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5DBus.so.5 (0x00007fdb6b868000)
        libQt5Positioning.so.5 => /nix/store/783fcjdrarz0kqzysrqnd5gxpy2r49ib-qtlocation-5.9.7/lib/libQt5Positioning.so.5 (0x00007fdb6b805000)
        libQt5Core.so.5 => /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Core.so.5 (0x00007fdb6b2ff000)
        libGL.so.1 => /nix/store/f2j6cvbzys5a3hr4h6266wmdwvsdk6jp-libGL-1.0.0/lib/libGL.so.1 (0x00007fdb6b26b000)
        libpthread.so.0 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/libpthread.so.0 (0x00007fdb6b24a000)
        libstdc++.so.6 => /nix/store/zma4brilgnwffh3qm8n9215frfj0n10g-gcc-7.4.0-lib/lib/../lib64/libstdc++.so.6 (0x00007fdb6b0be000)
        libm.so.6 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/libm.so.6 (0x00007fdb6af28000)
        libc.so.6 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/libc.so.6 (0x00007fdb6ad72000)
        libgcc_s.so.1 => /nix/store/zma4brilgnwffh3qm8n9215frfj0n10g-gcc-7.4.0-lib/lib/../lib64/libgcc_s.so.1 (0x00007fdb6ad59000)
        /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/ld-linux-x86-64.so.2 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib64/ld-linux-x86-64.so.2 (0x00007fdb73f10000)
        libXau.so.6 => /nix/store/2kryrbsfbnpby9hwqzcxgq8562x2kr05-libXau-1.0.8/lib/libXau.so.6 (0x00007fdb6ad54000)
        libXdmcp.so.6 => /nix/store/ln0c2xxp5n9l6avi3wxg05h8a72v3by4-libXdmcp-1.1.2/lib/libXdmcp.so.6 (0x00007fdb6ad4c000)
        libxcb-util.so.1 => /nix/store/ijisp5wwygn6yqv4smjapyfqxxysk0i8-xcb-util-0.4.0/lib/libxcb-util.so.1 (0x00007fdb6ad42000)
        libpcre.so.1 => /nix/store/pxkciklhcbsawajaqgknxi9r1ggl2mj1-pcre-8.42/lib/libpcre.so.1 (0x00007fdb6acce000)
        libsystemd.so.0 => /nix/store/k4s63l497v5viyqk507v2jxfndapddvd-systemd-239.20190219-lib/lib/libsystemd.so.0 (0x00007fdb6ac1d000)
        libQt5QuickWidgets.so.5 => /nix/store/y4sy7f4rxs2qyi9627xpj2f91hab18g1-qtdeclarative-5.9.7/lib/libQt5QuickWidgets.so.5 (0x00007fdb6ac06000)
        libgmodule-2.0.so.0 => /nix/store/6i3zqxizaliin2j4ag7fh7adwywhmhch-glib-2.58.2/lib/libgmodule-2.0.so.0 (0x00007fdb6abfd000)
        libgobject-2.0.so.0 => /nix/store/6i3zqxizaliin2j4ag7fh7adwywhmhch-glib-2.58.2/lib/libgobject-2.0.so.0 (0x00007fdb6aba1000)
        libgthread-2.0.so.0 => /nix/store/6i3zqxizaliin2j4ag7fh7adwywhmhch-glib-2.58.2/lib/libgthread-2.0.so.0 (0x00007fdb6ab9c000)
        libsmime3.so => /nix/store/f6jsdmrwx5d54mib9rgjkv45dnz619h1-nss-3.42/lib64/libsmime3.so (0x00007fdb6ab70000)
        libnss3.so => /nix/store/f6jsdmrwx5d54mib9rgjkv45dnz619h1-nss-3.42/lib64/libnss3.so (0x00007fdb6aa43000)
        libnssutil3.so => /nix/store/f6jsdmrwx5d54mib9rgjkv45dnz619h1-nss-3.42/lib64/libnssutil3.so (0x00007fdb6aa10000)
        libplds4.so => /nix/store/1jp715irnll6q7f9590fd66lzzpbg5gq-nspr-4.20/lib/libplds4.so (0x00007fdb6aa0b000)
        libplc4.so => /nix/store/1jp715irnll6q7f9590fd66lzzpbg5gq-nspr-4.20/lib/libplc4.so (0x00007fdb6aa04000)
        libnspr4.so => /nix/store/1jp715irnll6q7f9590fd66lzzpbg5gq-nspr-4.20/lib/libnspr4.so (0x00007fdb6a9c2000)
        libevent-2.1.so.6 => /nix/store/nlb60fnfplq6jf12pwihjdsrz4v2s1z4-libevent-2.1.8/lib/libevent-2.1.so.6 (0x00007fdb6a968000)
        libX11-xcb.so.1 => /nix/store/z6nlq8k2ba0cs0n2q8fqwzckjki2whrw-libX11-1.6.7/lib/libX11-xcb.so.1 (0x00007fdb6a963000)
        libXcomposite.so.1 => /nix/store/hnjrz6kssqd1qqmp9r1rlgp0dr8zswxv-libXcomposite-0.4.4/lib/libXcomposite.so.1 (0x00007fdb6a95e000)
        libXcursor.so.1 => /nix/store/1yprdm4z4iywmi9r1rn7idcv6bfw3mlk-libXcursor-1.1.15/lib/libXcursor.so.1 (0x00007fdb6a951000)
        libXdamage.so.1 => /nix/store/4mdzad3knhwqf59mvr1h4i3p2q7nfl56-libXdamage-1.1.4/lib/libXdamage.so.1 (0x00007fdb6a94c000)
        libXext.so.6 => /nix/store/585g56kwwbwcl14har03pp9ri3w2lnw2-libXext-1.3.3/lib/libXext.so.6 (0x00007fdb6a937000)
        libXi.so.6 => /nix/store/dxk8n1c6r5kx7043pzc1cm2zsqfp1vry-libXi-1.7.9/lib/libXi.so.6 (0x00007fdb6a922000)
        libXrender.so.1 => /nix/store/c8v7wsm6s0hi6zdwggb4psf7svssbsff-libXrender-0.9.10/lib/libXrender.so.1 (0x00007fdb6a915000)
        libXtst.so.6 => /nix/store/r7gl3rlg0qbaa0jc0qdfv62dc31syfzr-libXtst-1.2.3/lib/libXtst.so.6 (0x00007fdb6a90c000)
        libXss.so.1 => /nix/store/4r8l3p07aa7svnv80qsvawwdlycc7xxk-libXScrnSaver-1.2.3/lib/libXss.so.1 (0x00007fdb6a907000)
        libfontconfig.so.1 => /nix/store/shjh8jsn0k8c35pyqif4qxza02rdw7qv-fontconfig-2.12.6-lib/lib/libfontconfig.so.1 (0x00007fdb6a8bf000)
        libfreetype.so.6 => /nix/store/6c34rlvybgl7xcvbgychcpd0kfd6vyd6-freetype-2.9.1/lib/libfreetype.so.6 (0x00007fdb6a804000)
        libexpat.so.1 => /nix/store/p10krqbs61npps7mk362f0rv054w1ks7-expat-2.2.6/lib/libexpat.so.1 (0x00007fdb6a7ce000)
        libz.so.1 => /nix/store/k2b04j3h9qlycljfr8czy1ijmyx54hgr-zlib-1.2.11/lib/libz.so.1 (0x00007fdb6a7af000)
        libharfbuzz.so.0 => /nix/store/pzy8p1rxagsainmb596y7lx54q719mn8-harfbuzz-2.3.1/lib/libharfbuzz.so.0 (0x00007fdb6a6ab000)
        libpng16.so.16 => /nix/store/parrh56r6sr4ccp9ypl4sh7h5b19rijg-libpng-apng-1.6.36/lib/libpng16.so.16 (0x00007fdb6a672000)
        libjpeg.so.62 => /nix/store/c77839bs99lw2j87bfnvlpy99g52jsyp-libjpeg-turbo-2.0.1/lib/libjpeg.so.62 (0x00007fdb6a5da000)
        libXrandr.so.2 => /nix/store/ifw36x60dw1h00xpixwpq9wknc1m5lp2-libXrandr-1.5.1/lib/libXrandr.so.2 (0x00007fdb6a5cd000)
        libresolv.so.2 => /nix/store/sw54ph775lw7b9g4hlfvpx6fmlvdy8qi-glibc-2.27/lib/libresolv.so.2 (0x00007fdb6a5b2000)
        libopus.so.0 => /nix/store/8ci9bjl3b1hypm49029f3m2vv2g2w7vx-libopus-1.3/lib/libopus.so.0 (0x00007fdb6a553000)
        libasound.so.2 => /nix/store/p8qq2l55ayb20mn319gdv80cmvy995c0-alsa-lib-1.1.8/lib/libasound.so.2 (0x00007fdb6a44f000)
        libsnappy.so.1 => /nix/store/bwavf098d7c48in9mbl2i7jj0lp4pgds-snappy-1.1.7/lib/libsnappy.so.1 (0x00007fdb6a442000)
        libminizip.so.1 => /nix/store/qp8b64i17ms80pr9p8z1bv6jcsifgp4c-minizip-1.2.11/lib/libminizip.so.1 (0x00007fdb6a434000)
        libwebpdemux.so.2 => /nix/store/d2b6l29xa7srp8k6ylv5yi5qgbp0cnj7-libwebp-1.0.2/lib/libwebpdemux.so.2 (0x00007fdb6a42e000)
        libwebp.so.7 => /nix/store/d2b6l29xa7srp8k6ylv5yi5qgbp0cnj7-libwebp-1.0.2/lib/libwebp.so.7 (0x00007fdb6a3bb000)
        libEGL.so.1 => /nix/store/f2j6cvbzys5a3hr4h6266wmdwvsdk6jp-libGL-1.0.0/lib/libEGL.so.1 (0x00007fdb6a3a6000)
        libssl.so.1.0.0 => /nix/store/3fvdj5ipc1xp815dy3m9cigzczaknwgg-openssl-1.0.2q/lib/libssl.so.1.0.0 (0x00007fdb6a330000)
        libcrypto.so.1.0.0 => /nix/store/3fvdj5ipc1xp815dy3m9cigzczaknwgg-openssl-1.0.2q/lib/libcrypto.so.1.0.0 (0x00007fdb6a0c6000)
        libicui18n.so.59 => /nix/store/sfkxng2z0k2jcsrm81w50c900xsfmvf7-icu4c-59.1/lib/libicui18n.so.59 (0x00007fdb69e3e000)
        libicuuc.so.59 => /nix/store/sfkxng2z0k2jcsrm81w50c900xsfmvf7-icu4c-59.1/lib/libicuuc.so.59 (0x00007fdb69c88000)
        libicudata.so.59 => /nix/store/sfkxng2z0k2jcsrm81w50c900xsfmvf7-icu4c-59.1/lib/libicudata.so.59 (0x00007fdb68373000)
        libpcre2-16.so.0 => /nix/store/l1ak0a69anyc9k80swgnxx00v5cr05fv-pcre2-10.32/lib/libpcre2-16.so.0 (0x00007fdb682f6000)
        libGLX.so.0 => /nix/store/wxwgnkw7mi5kjxqpncqhqqm7mslgmin3-libglvnd-1.0.0/lib/libGLX.so.0 (0x00007fdb682c0000)
        libGLdispatch.so.0 => /nix/store/wxwgnkw7mi5kjxqpncqhqqm7mslgmin3-libglvnd-1.0.0/lib/libGLdispatch.so.0 (0x00007fdb68207000)
        liblzma.so.5 => /nix/store/rndhjkifmrp0rqi4mihd0n67sfh39dxl-xz-5.2.4/lib/liblzma.so.5 (0x00007fdb681de000)
        liblz4.so.1 => /nix/store/9kzy23nwk0d0pmz93arwcnfs4770v0ka-lz4-1.8.3/lib/liblz4.so.1 (0x00007fdb681a8000)
        libcap.so.2 => /nix/store/6v5fhg10g3b5zaqpp3rcw4hw1bwjwfjs-libcap-2.26-lib/lib/libcap.so.2 (0x00007fdb6819f000)
        libmount.so.1 => /nix/store/qswxiwzbl80c4b3krhnifyglprg415zx-util-linux-2.33.1/lib/libmount.so.1 (0x00007fdb68140000)
        libgcrypt.so.20 => /nix/store/fhbxjnc6pzndl02bh2x9p3gaacv32j5j-libgcrypt-1.8.4/lib/libgcrypt.so.20 (0x00007fdb68020000)
        libffi.so.6 => /nix/store/karxq4hlfmfj0c3yk4wv5mfaz06p70k8-libffi-3.2.1/lib/../lib64/libffi.so.6 (0x00007fdb68013000)
        libbz2.so.1 => /nix/store/3d88cf66llbhcwl3r8g5rmd24i6yh31p-bzip2-1.0.6.0.1/lib/libbz2.so.1 (0x00007fdb67fff000)
        libgraphite2.so.3 => /nix/store/g55pnb58jvmp1az9nlwb0sjas2rgwx1h-graphite2-1.3.6/lib/libgraphite2.so.3 (0x00007fdb67fca000)
        libblkid.so.1 => /nix/store/qswxiwzbl80c4b3krhnifyglprg415zx-util-linux-2.33.1/lib/libblkid.so.1 (0x00007fdb67f75000)
        libgpg-error.so.0 => /nix/store/sahixfdkcd7x1xsjzqrw9bmxw8c9nxdi-libgpg-error-1.34/lib/libgpg-error.so.0 (0x00007fdb67f4f000)

Time to find source of impurity!

@danbst
Copy link
Contributor

@danbst danbst commented Mar 6, 2019

@kamilchm can you also post your build log

nix log /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121

?

@kamilchm
Copy link
Member

@kamilchm kamilchm commented Mar 6, 2019

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/3njk9qn9k26lfpihp60syqlxriqd5r4b-zoom_x86_64.tar.xz
source root is zoom
setting SOURCE_DATE_EPOCH to timestamp 1548006393 of file zoom/zoom
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
building
no Makefile, doing nothing
@nix { "action": "setPhase", "phase": "glibPreInstallPhase" }
glibPreInstallPhase
@nix { "action": "setPhase", "phase": "installPhase" }
installing
@nix { "action": "setPhase", "phase": "glibPreFixupPhase" }
glibPreFixupPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121
shrinking /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/ZoomLauncher
shrinking /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zoom
shrinking /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zopen
strip is /nix/store/gqq2w8a0yb3ksx9h9iilp73x5hib3rwi-binutils-2.31.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/bin 
patching script interpreter paths in /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121
/nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zoomlinux: interpreter directive changed from "/bin/bash" to "/nix/store/53wi068kjrqfr2j0hzcxhbw2xaa990jr-bash-4.4-p23/bin/bash"
/nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zoom.sh: interpreter directive changed from "/bin/sh" to "/nix/store/53wi068kjrqfr2j0hzcxhbw2xaa990jr-bash-4.4-p23/bin/sh"
checking for references to /build/ in /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121...
automatically fixing dependencies for ELF files
/nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 213: echo: write error: Broken pipe
/nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 210: echo: write error: Broken pipe
searching for dependencies of /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zopen
  libQt5Widgets.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Widgets.so.5
  libQt5Gui.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Gui.so.5
  libQt5Core.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Core.so.5
  libGL.so.1 -> found: /nix/store/f2j6cvbzys5a3hr4h6266wmdwvsdk6jp-libGL-1.0.0/lib/libGL.so.1
  libstdc++.so.6 -> found: /nix/store/zma4brilgnwffh3qm8n9215frfj0n10g-gcc-7.4.0-lib/lib/../lib64/libstdc++.so.6
setting RPATH to: /nix/store/lgpwsa2vy78nipc37bpsl38nha992mr9-libpulseaudio-12.2/lib:/nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib:/nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib:/nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib:/nix/store/f2j6cvbzys5a3hr4h6266wmdwvsdk6jp-libGL-1.0.0/lib:/nix/store/zma4brilgnwffh3qm8n9215frfj0n10g-gcc-7.4.0-lib/lib/../lib64
@nix { "action": "setPhase", "phase": "postPatchMkspecs" }
postPatchMkspecs

@danbst
Copy link
Contributor

@danbst danbst commented Mar 6, 2019

automatically fixing dependencies for ELF files
/nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 213: echo: write error: Broken pipe
/nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 210: echo: write error: Broken pipe

This must be the problem. I have:

automatically fixing dependencies for ELF files
warning: working around a Linux kernel bug by creating a hole of 2088960 bytes in ‘/nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7>
searching for dependencies of /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/ZoomLauncher
  libstdc++.so.6 -> found: /nix/store/zma4brilgnwffh3qm8n9215frfj0n10g-gcc-7.4.0-lib/lib/../lib64/libstdc++.so.6
setting RPATH to: /nix/store/lgpwsa2vy78nipc37bpsl38nha992mr9-libpulseaudio-12.2/lib:/nix/store/zma4brilgnwffh3qm8n9215frfj0n10g-gcc-7.4.0>
searching for dependencies of /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zopen
  libQt5Widgets.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Widgets.so.5
  libQt5Gui.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Gui.so.5
  libQt5Core.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Core.so.5
  libGL.so.1 -> found: /nix/store/f2j6cvbzys5a3hr4h6266wmdwvsdk6jp-libGL-1.0.0/lib/libGL.so.1
  libstdc++.so.6 -> found: /nix/store/zma4brilgnwffh3qm8n9215frfj0n10g-gcc-7.4.0-lib/lib/../lib64/libstdc++.so.6
setting RPATH to: /nix/store/lgpwsa2vy78nipc37bpsl38nha992mr9-libpulseaudio-12.2/lib:/nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.>
searching for dependencies of /nix/store/c7az0vsj7a36jdcpzp0v9b0fbmr9vw2z-zoom-us-2.7.162522.0121/share/zoom-us/zoom
  libuuid.so.1 -> found: /nix/store/qswxiwzbl80c4b3krhnifyglprg415zx-util-linux-2.33.1/lib/libuuid.so.1
  libX11.so.6 -> found: /nix/store/z6nlq8k2ba0cs0n2q8fqwzckjki2whrw-libX11-1.6.7/lib/libX11.so.6
  libxcb.so.1 -> found: /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb.so.1
  libxcb-xfixes.so.0 -> found: /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb-xfixes.so.0
  libxcb-shape.so.0 -> found: /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb-shape.so.0
  libxcb-shm.so.0 -> found: /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb-shm.so.0
  libxcb-randr.so.0 -> found: /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb-randr.so.0
  libxcb-image.so.0 -> found: /nix/store/5xwpvcaa46l2xzr9ahc7p9d0l33x2ybl-xcb-util-image-0.4.0/lib/libxcb-image.so.0
  libxcb-keysyms.so.1 -> found: /nix/store/36jhcylqyfp0lpsm822hbxsj5g6lba2f-xcb-util-keysyms-0.4.0/lib/libxcb-keysyms.so.1
  libxcb-xtest.so.0 -> found: /nix/store/qi8s5srwx75l293drnlqvfb8mnhapxa4-libxcb-1.13.1/lib/libxcb-xtest.so.0
  libXfixes.so.3 -> found: /nix/store/kf9q21bg2bryl03q8jqd8gl58fn0sfp4-libXfixes-5.0.3/lib/libXfixes.so.3
  libglib-2.0.so.0 -> found: /nix/store/6i3zqxizaliin2j4ag7fh7adwywhmhch-glib-2.58.2/lib/libglib-2.0.so.0
  libdbus-1.so.3 -> found: /nix/store/i8sjz5xjcihqwwm9232mz6fcj718jnyl-dbus-1.12.12-lib/lib/libdbus-1.so.3
  libQt5WebEngineWidgets.so.5 -> found: /nix/store/rj8kdjc2digg548rvsi9n2llbpwrm4cl-qtwebengine-5.9.7/lib/libQt5WebEngineWidgets.so.5
  libQt5WebEngineCore.so.5 -> found: /nix/store/rj8kdjc2digg548rvsi9n2llbpwrm4cl-qtwebengine-5.9.7/lib/libQt5WebEngineCore.so.5
  libQt5Quick.so.5 -> found: /nix/store/y4sy7f4rxs2qyi9627xpj2f91hab18g1-qtdeclarative-5.9.7/lib/libQt5Quick.so.5
  libQt5PrintSupport.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5PrintSupport.so.5
  libQt5Widgets.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Widgets.so.5
  libQt5Gui.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Gui.so.5
  libQt5WebChannel.so.5 -> found: /nix/store/rqvx0f3g2cdlv066z1jqj1ys5qcgvxbj-qtwebchannel-5.9.7/lib/libQt5WebChannel.so.5
  libQt5Qml.so.5 -> found: /nix/store/y4sy7f4rxs2qyi9627xpj2f91hab18g1-qtdeclarative-5.9.7/lib/libQt5Qml.so.5
  libQt5Network.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Network.so.5
  libQt5Script.so.5 -> found: /nix/store/qcxrirg55wsqlk2g269ajkzrn1y5z7av-zoom-us-qt-5.9.7/lib/libQt5Script.so.5
  libQt5DBus.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5DBus.so.5
  libQt5Positioning.so.5 -> found: /nix/store/783fcjdrarz0kqzysrqnd5gxpy2r49ib-qtlocation-5.9.7/lib/libQt5Positioning.so.5
  libQt5Core.so.5 -> found: /nix/store/ydkvwzfq5qjgcs9zj1msrkvxhyqwggcg-qtbase-5.9.7/lib/libQt5Core.so.5
  libGL.so.1 -> found: /nix/store/f2j6cvbzys5a3hr4h6266wmdwvsdk6jp-libGL-1.0.0/lib/libGL.so.1
  libstdc++.so.6 -> found: /nix/store/zma4brilgnwffh3qm8n9215frfj0n10g-gcc-7.4.0-lib/lib/../lib64/libstdc++.so.6
setting RPATH to: /nix/store/lgpwsa2vy78nipc37bpsl38nha992mr9-libpulseaudio-12.2/lib:/nix/store/qswxiwzbl80c4b3krhnifyglprg415zx-util-linu>
@nix { "action": "setPhase", "phase": "postPatchMkspecs" }
postPatchMkspecs

Can you rebuild derivation, say, nix-build '<nixpkgs>' -A zoom-us --check? If it says that there is mismatch, then there was transient problem during building previous derivation. Fixing it up should consists of removing store path from nix store, and adding it back with nix-build(but I've never done this, so not sure)

@danbst
Copy link
Contributor

@danbst danbst commented Mar 6, 2019

@flokli @kamilchm I've opened a PR, which should address original issue. But I can't reproduce the issue on my laptop.

@kamilchm
Copy link
Member

@kamilchm kamilchm commented Mar 6, 2019

I tested you patch and zoom works for me now! Thx.

danbst added a commit to danbst/nixpkgs that referenced this issue Mar 13, 2019
This rare sitation was caught when building zoom-us package:
```
automatically fixing dependencies for ELF files
/nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 213: echo: write error: Broken pipe
/nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 210: echo: write error: Broken pipe
```

The worst is that derivation continued and resulted into broken package:
NixOS#55566 (comment)

I hope, replacing `grep -q` with `grep` will remove this race condition.
pull bot pushed a commit to milibopp/nixpkgs that referenced this issue Mar 20, 2019
This rare sitation was caught when building zoom-us package:
```
automatically fixing dependencies for ELF files
/nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 213: echo: write error: Broken pipe
/nix/store/71d65fplq44y9yn2fvkpn2d3hrszracd-auto-patchelf-hook/nix-support/setup-hook: line 210: echo: write error: Broken pipe
```

The worst is that derivation continued and resulted into broken package:
NixOS#55566 (comment)

I hope, replacing `grep -q` with `grep` will remove this race condition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants