Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_hardkernel_4_14: don't apply interpreter-trunc patch #55861

Merged

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

This patch was mistakenly applied in f0b8a11 and broke the build. The only 4.14.y versions that need the patch are 4.14.99 and 4.14.100.

Things done

Removed the patch.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The only 4.14.y versions that need the patch are 4.14.99 and 4.14.100.
@qolii
Copy link
Contributor

qolii commented Feb 16, 2019

Thanks, @lopsided98!

@samueldr
Copy link
Member

Linking #53672 to remember to touch on this in an eventual post-mortem.

@samueldr
Copy link
Member

[release-18.09 e181504] linux_hardkernel_4_14: don't apply interpreter-trunc patch
Date: Fri Feb 15 18:56:55 2019 -0500
1 file changed, 1 deletion(-)

@lopsided98 lopsided98 deleted the linux-hardkernel-interpreter-trunc branch February 16, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants