Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gromit-mpx: 1.2 -> 1.3 #56275

Merged
merged 1 commit into from Feb 24, 2019
Merged

gromit-mpx: 1.2 -> 1.3 #56275

merged 1 commit into from Feb 24, 2019

Conversation

pjones
Copy link
Contributor

@pjones pjones commented Feb 24, 2019

Motivation for this change

Upgrade package gromit-mpx from version 1.2 to 1.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Additional Notes

On nixpkgs/master there is a problem with GDK which causes gromit-mpx to exit with a segmentation fault. This problem does not exist on the channels/18.09 branch:

Program received signal SIGSEGV, Segmentation fault.
0x00007fffee4bf390 in pixbuf_create_from_xpm ()
   from /nix/store/dap6ngds92w3d2x7gg3fl8i4pp123dd3-gdk-pixbuf-2.36.12/lib/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-xpm.so
(gdb) bt
#0  0x00007fffee4bf390 in pixbuf_create_from_xpm ()
   from /nix/store/dap6ngds92w3d2x7gg3fl8i4pp123dd3-gdk-pixbuf-2.36.12/lib/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-xpm.so
#1  0x00007fffee4bf701 in gdk_pixbuf.xpm_image_load_xpm_data ()
   from /nix/store/dap6ngds92w3d2x7gg3fl8i4pp123dd3-gdk-pixbuf-2.36.12/lib/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-xpm.so
#2  0x00007ffff75b4d71 in gdk_pixbuf_new_from_xpm_data ()
   from /nix/store/vyibwikjzxwr2l19xhz3b5zmrj73d8sw-gdk-pixbuf-2.38.0/lib/libgdk_pixbuf-2.0.so.0
#3  0x00000000004090ec in setup_main_app (data=data@entry=0x4ad050, activate=0)
    at /build/source/src/gromit-mpx.c:681
#4  0x0000000000405d1c in main (argc=<optimized out>, argv=<optimized out>)
    at /build/source/src/gromit-mpx.c:1264

NOTE: The existing package for gromit-mpx (version 1.2) also seg faults in the same place on nixpkgs/master.

@etu
Copy link
Contributor

etu commented Feb 24, 2019

@GrahamcOfBorg build gromit-mpx

@etu
Copy link
Contributor

etu commented Feb 24, 2019

I'm not waiting for the darwin build since it will just say that it's an unsupported platform anyways.

I've tried this on master on my nixos-unstable system that runs X11. And both the one in master and this updated version works for me. So I'm not sure what's different for @pjones... But thanks for the update of the package 🙂

@etu etu merged commit c69915d into NixOS:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants