Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird: 60.5.1 -> 60.5.2 #56640

Merged
merged 2 commits into from
Mar 2, 2019
Merged

thunderbird: 60.5.1 -> 60.5.2 #56640

merged 2 commits into from
Mar 2, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Mar 2, 2019

Motivation for this change
  • Bug fixes

https://www.thunderbird.net/en-US/thunderbird/60.5.2/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested review from edolstra and nbp March 2, 2019 04:31
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 2, 2019
@vcunat vcunat self-assigned this Mar 2, 2019
vcunat
vcunat approved these changes Mar 2, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used both for some time. The changes seem safe anyway.

@vcunat vcunat merged commit 202f713 into NixOS:master Mar 2, 2019
vcunat added a commit that referenced this pull request Mar 2, 2019
@vcunat
Merge #56640: thunderbird: 60.5.1 -> 60.5.2
7914b8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taku0 @vcunat @GrahamcOfBorg