Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.py3status: Added missing Python dependencies #56703

Merged
merged 1 commit into from
Mar 23, 2019
Merged

pythonPackages.py3status: Added missing Python dependencies #56703

merged 1 commit into from
Mar 23, 2019

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Mar 2, 2019 •
edited
Loading

Motivation for this change

According to py3status' modules documentation 1:

  • i3ipc: Used by scratchpad_async and window_title_async modules.
  • pydbus: Used by kdeconnector, mpris, systemd, vpn_status and wwan
    modules.
  • pyserial: Used by wwan_status module.

Tested with my current py3status configuration, some modules that depends on i3ipc or py3dbus works. Did not test pyserial because I don't have a wwan to test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada thiagokokada requested a review from FRidh as a code owner March 2, 2019 15:08
@thiagokokada
python.pkgs.py3status: Added missing Python deps
83dcc06 
According to py3status' modules documentation [1]:

- i3ipc: Used by scratchpad_async and window_title_async modules.
- pydbus: Used by kdeconnector, mpris, systemd, vpn_status and wwan
modules.
- pyserial: Used by wwan_status module.

[1]: https://py3status.readthedocs.io/en/latest/modules.html
@GrahamcOfBorg GrahamcOfBorg requested a review from garbas March 2, 2019 15:38
@dotlambda dotlambda changed the title py3status: Added missing Python dependencies pythonPackages.py3status: Added missing Python dependencies Mar 23, 2019
@dotlambda dotlambda merged commit 8820a7a into NixOS:master Mar 23, 2019
@thiagokokada thiagokokada deleted the add-missing-py-deps-in-py3status branch March 23, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thiagokokada @dotlambda @GrahamcOfBorg