Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.qscintilla: fix build #56811

Merged
merged 1 commit into from Mar 4, 2019
Merged

pythonPackages.qscintilla: fix build #56811

merged 1 commit into from Mar 4, 2019

Conversation

lsix
Copy link
Member

@lsix lsix commented Mar 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lsix lsix requested a review from FRidh as a code owner March 4, 2019 10:55
@FRidh
Copy link
Member

FRidh commented Mar 4, 2019

Ahh, also related to the strictDeps change. This one was really vague. Thanks for fixing.

@danbst danbst merged commit ba519fb into NixOS:master Mar 4, 2019
@lsix lsix deleted the fix-qscintilla branch August 22, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@danbst danbst Awaiting requested review from danbst

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lsix @FRidh @danbst @GrahamcOfBorg