Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closure graph memory (19.03) #56920

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Closure graph memory (19.03) #56920

merged 2 commits into from
Mar 7, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Mar 5, 2019

Motivation for this change

Backport #56918

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

grahamc added 2 commits March 5, 2019 17:35
@grahamc
references-by-popularity: create debug output
f17c143 
(cherry picked from commit 54826e7)
@grahamc
references-by-popularity: cache computation to avoid memory bloat
4991792 
On very large graphs (14k+ paths), we'd end up with a massive in
memory tree of mostly duplication.

We can safely cache trees and point back to them later, saving
memory.

(cherry picked from commit 09362bc)
@worldofpeace
Copy link
Contributor

Fixed the little evaluation bleep 2fc4252

@shlevy
Copy link
Member

shlevy commented Mar 6, 2019

@GrahamcOfBorg eval

@shlevy
Copy link
Member

shlevy commented Mar 6, 2019

@grahamc Have the ofborg commands changed?

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 6, 2019
@shlevy shlevy merged commit a8a6e9e into NixOS:release-19.03 Mar 7, 2019
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge pull request NixOS#56920 from grahamc/closure-graph-memory-19.03
188a06b 
Closure graph memory (19.03)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grahamc @worldofpeace @shlevy @GrahamcOfBorg