Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teensyduino: 1.40 -> 1.45 #56936

Merged
merged 1 commit into from Mar 7, 2019
Merged

teensyduino: 1.40 -> 1.45 #56936

merged 1 commit into from Mar 7, 2019

Conversation

witchof0x20
Copy link
Contributor

@witchof0x20 witchof0x20 commented Mar 6, 2019

Motivation for this change

On my system, teensyduino cannot build due to #33147

This resolves the issue by using jars from the officially distributed arduino package to get past the file size checks.
I also upgrade teensyduino to version 1.45, which removes the need to simulate clicks in an X server to perform the install.
Additionally, I add a variable to parameterize the teensyduino version.

These changes are more-or-less in line with that the Arch Linux PKGBUILD does, though their version relies purely on the distributed Arduino package, and does not build it from source.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Bumps teensyduino version, simplifies building, and fixes a build error
@witchof0x20
Copy link
Contributor Author

Per #33147, the additional source is not necessary if this is compiled with jdk 8u144, but adding in an override for the JDK version seems much more complex.

@witchof0x20
Copy link
Contributor Author

I don't have an x86 system to test, but it's entirely possible that this fixes https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/arduino/arduino-core/default.nix#L12

@witchof0x20 witchof0x20 changed the title Upgrade teensyduino teensyduino: 1.40 -> 1.45 Mar 7, 2019
@Mic92 Mic92 merged commit 3aa7d41 into NixOS:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants