Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udocker: Fix build #57002

Merged
merged 1 commit into from Mar 7, 2019
Merged

udocker: Fix build #57002

merged 1 commit into from Mar 7, 2019

Conversation

knedlsepp
Copy link
Member

Motivation for this change

The latest changes to support better cross-compilation compatibility
have introduced a stricter handling of dependency specifications in
python. Since b4acd97, mock and nosetest should be checkInputs, since
they are used for testing.

Fixes: #56972

Please backport to 19.03.
ZHF-19.03: #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp
udocker: Fix build
2672549 
The latest changes to support better cross-compilation compatibility
have introduced a stricter handling of dependency specifications in
python. Since b4acd97, mock and nosetest should be checkInputs, since
they are used for testing.

Fixes: NixOS#56972
@xeji xeji merged commit 61a8aca into NixOS:master Mar 7, 2019
xeji pushed a commit that referenced this pull request Mar 7, 2019
@knedlsepp @xeji
udocker: Fix build (#57002)
68cb706 
The latest changes to support better cross-compilation compatibility
have introduced a stricter handling of dependency specifications in
python. Since b4acd97, mock and nosetest should be checkInputs, since
they are used for testing.

Fixes: #56972
(cherry picked from commit 61a8aca)
@xeji
Copy link
Contributor

xeji commented Mar 7, 2019

backported to 19.03: 68cb706

@knedlsepp
Copy link
Member Author

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @xeji @GrahamcOfBorg