Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Janet programming language. #57549

Merged
merged 3 commits into from Mar 30, 2019
Merged

Conversation

andrewchambers
Copy link
Contributor

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff --git a/pkgs/development/interpreters/janet/default.nix b/pkgs/development/interpreters/janet/default.nix
--- a/pkgs/development/interpreters/janet/default.nix
+++ b/pkgs/development/interpreters/janet/default.nix
@@ -1,4 +1,5 @@
 { stdenv, fetchFromGitHub }:
+
 stdenv.mkDerivation rec {
   name = "janet-${version}";

@@ -11,18 +12,10 @@ stdenv.mkDerivation rec {
     sha256 = "1590f1fxb6qfhf1vp2xhbvdn2jfrgipn5572cckk1ma7f13jnkpy";
   };

-  buildInputs = [ ];
-
   JANET_BUILD=''\"v${version}\"'';
+  PREFIX = placeholder "out";

-  buildPhase = ''
-    PREFIX="$out" make
-  '';
-
-  installPhase = ''
-    mkdir "$out"
-    PREFIX="$out" make install
-  '';
+  doCheck = true;

   meta = with stdenv.lib; {
     description = "Janet programming language";

@veprbl
Copy link
Member

veprbl commented Mar 30, 2019

@GrahamcOfBorg build janet

@veprbl veprbl merged commit 49d4668 into NixOS:master Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants