Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use llvmPackages_7 explicitly for ccls #57565

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Use llvmPackages_7 explicitly for ccls #57565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8589,8 +8589,8 @@ in
};

ccls = callPackage ../development/tools/misc/ccls {
llvmPackages = llvmPackages_latest;
stdenv = llvmPackages_latest.stdenv;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be llvm_8 right now, so this is a downgrade to llvm_7.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe the actual problem is, that it does not work with llvm 8.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. That might actually be it. Maybe the version 5 thing was me misreading build output.

llvmPackages = llvmPackages_7;
stdenv = llvmPackages_7.stdenv;
};

credstash = with python3Packages; toPythonApplication credstash;
Expand Down