Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xscreensaver: Enable perl modules needed for RSS image fetch (#57629) #57668

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@booxter
Copy link
Contributor

booxter commented Mar 14, 2019

(cherry picked from commit 4730466)

@booxter

This comment has been minimized.

Copy link
Contributor Author

booxter commented Mar 14, 2019

@7c6f434c this is xscreensaver perl backport. It required a slight adjustment to fit the branch. I am not sure if it's customary in this project to include adjustments as a separate patch on top or to meld it into the original cherry-picked commit. Here, I melded it in the original one, but if it's done differently here, please tell me.

Thanks.

@GrahamcOfBorg GrahamcOfBorg requested a review from 7c6f434c Mar 14, 2019

@7c6f434c 7c6f434c merged commit fdb5b68 into NixOS:release-18.09 Mar 15, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@7c6f434c

This comment has been minimized.

Copy link
Member

7c6f434c commented Mar 15, 2019

We try to have commits that make sense on their own; so what you did is clearly the best possible way in this case, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.