Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activator: remove attribute name #57735

Merged
merged 1 commit into from
Mar 16, 2019
Merged

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 16, 2019

Motivation for this change

Back in 2017 I removed the activator package (see 25a3563)
as it reached its end of life. Almost 2 years later everyone
shouldn't reference to this (not evaluating) path anymore
and hence can be removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Back in 2017 I removed the `activator` package (see 25a3563)
as it reached its end of life. Almost 2 years later everyone
shouldn't reference to this (not evaluating) path anymore
and hence can be removed.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 16, 2019
@xeji xeji merged commit 0610d30 into NixOS:master Mar 16, 2019
@Ma27 Ma27 deleted the rm-activator-attribute branch March 16, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants