Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sl: 5.02 -> 5.04 #57915

Merged
merged 1 commit into from Mar 20, 2019
Merged

sl: 5.02 -> 5.04 #57915

merged 1 commit into from Mar 20, 2019

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Mar 19, 2019

Motivation for this change

Many additional features that the original author would not merge.
So I have forked it, merged the changes I saw would help the most and added some additional things too.

I have added myself as maintainer for this!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Mar 20, 2019

@GrahamcOfBorg build sl

@grahamc grahamc merged commit 3b7c3cb into NixOS:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants