-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.elasticsearch-curator: pass "click" dependency in version 6.7 #58023
Conversation
…t is incompatible with version 7.0
@@ -1809,7 +1809,9 @@ in { | |||
# alias | |||
elasticsearchdsl = self.elasticsearch-dsl; | |||
|
|||
elasticsearch-curator = callPackage ../development/python-modules/elasticsearch-curator { }; | |||
elasticsearch-curator = callPackage ../development/python-modules/elasticsearch-curator { | |||
click = callPackage ../development/python-modules/click { version = "6.7"; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't do that for Python packages as multiple versions of the same package can't be in $PYTHONPATH
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use packageOverrides
if elasticsearch-curator was only an application. However, according to https://github.com/elastic/curator#curator-api-documentation it also has an API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:( That's the end of my python knowledge, tbh. I only use the module, which use elastic-curator as an application:
"${pkgs.python3Packages.elasticsearch-curator}/bin/curator" + |
Sorry, I missed that issue. I'll take a look later if it's not done by
then.
…On Thu, Mar 21, 2019, 11:03 Johan Thomsen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/top-level/python-packages.nix
<#58023 (comment)>:
> @@ -1809,7 +1809,9 @@ in {
# alias
elasticsearchdsl = self.elasticsearch-dsl;
- elasticsearch-curator = callPackage ../development/python-modules/elasticsearch-curator { };
+ elasticsearch-curator = callPackage ../development/python-modules/elasticsearch-curator {
+ click = callPackage ../development/python-modules/click { version = "6.7"; };
:( That's the end of my python knowledge, tbh. I only use the module,
which use elastic-curator as an application:
https://github.com/NixOS/nixpkgs/blob/be1c03ddaf867e9a58499cd790d5cd72cffc6fca/nixos/modules/services/search/elasticsearch-curator.nix#L89
.. So I'd be fine with packageOverride or simply wrapping the binary, but I
don't know what other usecases for this package that would destroy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58023 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANY4pznC_ccV2njtR-hzZc3-b2pKTqFks5vY1jVgaJpZM4cA_X5>
.
|
See NixOS#58023 for a discussion of why this is necessary. The upstream issue can be found at elastic/curator#1280.
See NixOS#58023 for a discussion of why this is necessary. The upstream issue can be found at elastic/curator#1280. (cherry picked from commit c0409de)
Motivation for this change
Improving the fix from #57912 by passing click in version 6.7 to elasticsearch-curator, since according to elastic/curator#1280, it is not compatible with click v7.0.
This should be backported to 19.03 as well.
cc @srhb @dotlambda
@GrahamcOfBorg build pythonPackages.elasticsearch-curator pythonPackages.click
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)