Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.cartopy: fix build #58361

Merged
merged 1 commit into from Mar 26, 2019
Merged

python.pkgs.cartopy: fix build #58361

merged 1 commit into from Mar 26, 2019

Conversation

dotlambda
Copy link
Member

Motivation for this change

fallout of #54182

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @mredaelli

@dotlambda dotlambda requested a review from FRidh as a code owner March 26, 2019 12:38
@dotlambda dotlambda changed the title python.pkgs.cartopy: fix build: python.pkgs.cartopy: fix build Mar 26, 2019
@dotlambda dotlambda mentioned this pull request Mar 26, 2019
Merged
@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 26, 2019
@dotlambda dotlambda merged commit 29cec94 into NixOS:master Mar 26, 2019
@dotlambda dotlambda deleted the cartopy-fix branch March 26, 2019 15:49
dotlambda added a commit that referenced this pull request Mar 26, 2019
@dotlambda
python.pkgs.cartopy: fix build (#58361)
409b46d 
fallout of #54182

(cherry picked from commit 29cec94)
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @FRidh @samueldr @GrahamcOfBorg