New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuse3: use /etc/fuse.conf for configuration #59043
Conversation
We don’t want the config file to be read only.
(Review per top comment in Reviewed points
Possible improvements
Comments
|
@Yarny0 thank you very much for the great review :) Regarding the possible improvement: Yes, that's a good idea but I also have some doubts that the behaviour could change in the future. Since I don't mind updating the patch if the file changes I'll merge it as it is but we/I could consider making an upstream PR to make it easier to configure (e.g. by introducing a Meson option). And thanks for the pinging me :) Edit: @matthewbauer I've changed the commit message slightly - hope that's ok. |
We don’t want the config file to be read only and in the Nix store. (cherry picked from commit 5541559) Reason: Backport a trivial fix for NixOS#59021.
[19.03] fuse3: use /etc/fuse.conf for configuration (backport of #59043)
Backported to 19.03 in #59166. Since 19.03 should be released very soon (today?) it should be okay to skip 18.09 (feel free to make a PR and/or ping me if someone desperately needs this on 18.09 ;). |
We don’t want the config file to be read only.
Fixes #59021
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)