Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppp: add eap-tls patch #59064

Merged
merged 1 commit into from Apr 7, 2019
Merged

ppp: add eap-tls patch #59064

merged 1 commit into from Apr 7, 2019

Conversation

teto
Copy link
Member

@teto teto commented Apr 6, 2019

else NetworkManager-l2tp fails with:
checking whether EAP-TLS patch has been applied to pppd... no
configure: error: EAP-TLS patch has not been applied to pppd

This check has been added in nm-l2tp/NetworkManager-l2tp@56e82af,
i.e. l2tp version 1.7.0.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

else NetworkManager-l2tp fails with:
checking whether EAP-TLS patch has been applied to pppd... no
configure: error: EAP-TLS patch has not been applied to pppd

This check has been added in nm-l2tp/NetworkManager-l2tp@56e82af,
i.e. l2tp version 1.7.0.
@falsifian
Copy link
Contributor

Thanks!

@teto teto deleted the ppp branch April 7, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants