Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphene-hardened-malloc: init at 190405.003.2019.04.01.19 #59140

Merged
merged 1 commit into from Apr 18, 2019
Merged

graphene-hardened-malloc: init at 190405.003.2019.04.01.19 #59140

merged 1 commit into from Apr 18, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 7, 2019 •
edited

Motivation for this change

This is an interesting new hardened malloc implementation by the GrapheneOS people.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle changed the title graphene-hardened-malloc: init at PQ2A.190405.003.2019.04.01.19 graphene-hardened-malloc: init at 190405.003.2019.04.01.19 Apr 16, 2019
@risicle risicle force-pushed the ris-graphene-hardened-malloc branch 2 times, most recently from 8828031 to 35dca98 Compare April 16, 2019 22:35
@risicle risicle force-pushed the ris-graphene-hardened-malloc branch from 35dca98 to 16987b9 Compare April 16, 2019 22:38
@joachifm joachifm merged commit cc2b6f3 into NixOS:master Apr 18, 2019
@joachifm
Copy link
Contributor

@risicle in case you're interested, see #59955 Suggestions welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @joachifm @GrahamcOfBorg