Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samba: 4.7.10 -> 4.10.2 #59144

Merged
merged 1 commit into from Apr 14, 2019
Merged

samba: 4.7.10 -> 4.10.2 #59144

merged 1 commit into from Apr 14, 2019

Conversation

aneeshusa
Copy link
Contributor

@aneeshusa aneeshusa commented Apr 8, 2019

Release notes: https://www.samba.org/samba/history/samba-4.10.2.html
Notably, Samba 4.10.0 is the first with Python 3 support,
and the 4.10 line will be the last supporting Python 2,
so switch to Python 3.

Add myself as a maintainer.

Motivation for this change

I set up Samba and wanted to use an up-to-date version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [WIP] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [WIP] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aneeshusa aneeshusa marked this pull request as ready for review April 8, 2019 02:29
@aneeshusa
Copy link
Contributor Author

@GrahamcOfBorg test samba

@xeji
Copy link
Contributor

xeji commented Apr 9, 2019

@GrahamcOfBorg build samba sambaFull

@xeji
Copy link
Contributor

xeji commented Apr 10, 2019

Local build of sambaFull on x86_64-linux fails in configurePhase with
Samba AD DC and --enable-selftest requires lmdb 0.9.16 or later
(based on master 180aa21 with this PR)

Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix build, see comments and ofborg logs

@bachp
Copy link
Member

bachp commented Apr 12, 2019

There is already Samba 4.10.2 with two additional CVE fixes: https://www.samba.org/samba/history/samba-4.10.2.html

@bachp
Copy link
Member

bachp commented Apr 12, 2019

samba is sucessfully building and working. Tested it on my server.

sambaFull fails with the message mentioned by @xeji. Adding lmdb and gpgme to buildInputs makes it compile.

Release notes: https://www.samba.org/samba/history/samba-4.10.2.html
Notably, Samba 4.10.0 is the first with Python 3 support,
and the 4.10 line will be the last supporting Python 2,
so switch to Python 3.

Add myself as a maintainer.
@aneeshusa aneeshusa changed the title samba: 4.7.10 -> 4.10.1 samba: 4.7.10 -> 4.10.2 Apr 13, 2019
@aneeshusa
Copy link
Contributor Author

@GrahamcOfBorg build samba sambaFull

@aneeshusa
Copy link
Contributor Author

@GrahamcOfBorg test samba

@aneeshusa
Copy link
Contributor Author

Thanks for the reviews @xeji @bachp, updated to 4.10.2 and added the missing deps. (I didn't even realize we had a sambaFull!)

Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both samba and sambaFull are now working

@xeji xeji merged commit c9e9c48 into NixOS:master Apr 14, 2019
@aneeshusa aneeshusa deleted the update-samba-to-4.10.1 branch January 7, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants