Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune: 1.8.2 -> 1.9.0 #59263

Merged
merged 1 commit into from Apr 11, 2019
Merged

dune: 1.8.2 -> 1.9.0 #59263

merged 1 commit into from Apr 11, 2019

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Apr 10, 2019

Motivation for this change

Package update. Personal motivation: Dune 1.9.0 introduces Coq support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested a review from vbgl April 10, 2019 13:25
@basvandijk
Copy link
Member

@GrahamcOfBorg build dune

@basvandijk
Copy link
Member

Let's also check if dune is able to build other packages:

@GrahamcOfBorg build ocamlPackages.conduit

@basvandijk basvandijk merged commit 1a926b8 into NixOS:master Apr 11, 2019
@Zimmi48 Zimmi48 deleted the dune-1.9.0 branch April 16, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zimmi48 @basvandijk @matthiasbeyer @GrahamcOfBorg