Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.pomodoro: 0.13.4 -> 0.15.1 #59298

Merged
merged 3 commits into from Apr 18, 2019
Merged

gnome3.pomodoro: 0.13.4 -> 0.15.1 #59298

merged 3 commits into from Apr 18, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fix build because it's failing in staging-next https://hydra.nixos.org/build/91945945
due to the vala bump. Then noticed it was pretty out of date.

This brings in a new package Gom.
I had to make an MR to it because of the PyGObject override

Things done

Built and executed, haven't tested the shell extension though.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

This test reached timeout on ofborg. Maybe it won't be a problem on hydra 🤔

@jtojnar
Copy link
Contributor

jtojnar commented Apr 11, 2019

Hmm, I am encountering

https://gitlab.gnome.org/GNOME/gom/issues/22

@worldofpeace
Copy link
Contributor Author

Hmm, I am encountering

https://gitlab.gnome.org/GNOME/gom/issues/22

ofborg was too. I could bump the timeout to 500 if that sounds reasonable?

bobvanderlinden
bobvanderlinden approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@bobvanderlinden bobvanderlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build and run this. 👍

@worldofpeace worldofpeace merged commit eb095fa into NixOS:master Apr 18, 2019
@worldofpeace worldofpeace deleted the gnome-pomodoro branch April 18, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobvanderlinden bobvanderlinden bobvanderlinden approved these changes

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@worldofpeace @jtojnar @bobvanderlinden @GrahamcOfBorg @markuskowa