texlive: add missing perl dependencies for latexindent

[veprbl]

Motivation for this change

Resolves: #35537
Improves on previous version #54518

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

cc @volth @romildo
cc #55933

[veprbl]

Forgot to mention. This was tested by running:

nix-shell -p "texlive.combine { inherit (texlive) scheme-minimal latexindent; }" \
  --pure --run latexindent

[dtzWill]

Is it indeed needed / useful for this to have the perl deps propagated here? I'm tracking down recent regression that caused shebang length to explode and looking for possible causes, is why I'm asking :).

[veprbl]

@dtzWill Yes, it is needed. When doing the original #54518 I initially tried to add things manually, but there were too many needed "higher order" dependencies, so I had to go for lib.closePropagation there.

[dtzWill]

On Fri, 10 May 2019 05:48:14 -0700, Dmitry Kalinkin ***@***.***> wrote: @dtzWill Yes, it is needed. When doing the original #54518 I initially tried to add things manually, but there were too many needed "higher order" dependencies, so I had to go for `lib.closePropagation` there.

D'oh, okay. Thanks and +1 for only propagating them reluctantly when other efforts were insufficient :). For now I've kludged it locally which seems to have fixed my problem but it's not really suitable otherwise. ( 986fcbc for the curious) Hopefully the recent efforts re:managing perl deps will improve things, some of the shebang lines we create are just silly :D.

…

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #59537 (comment) part: text/html

[veprbl]

+1 for only propagating them reluctantly when other efforts were insufficient :)

Actually the reason for adding dependencies manually was because the use of lib.closePropagation is discouraged for some reason. I'm not knowledgeable about Perl, but all imports there seemed unconditional, so I did not expect to be able to cut down any dependencies that way. If that was possible, then those should have been fixed in the relevant perl packages instead. Also, setting dependencies manually is not very maintainable.

Judging from conclusions of #55786 your workaround appears to be an actual canonical solution. Perhaps we should merge it to fix "latexindent" on macOS.

[veprbl]

For some reason applying 986fcbc doesn't fix the issue, I still get the same error on macOS:

# nix-shell -p "texlive.combine { inherit (texlive) scheme-minimal latexindent; }" --pure --run latexindent
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 20: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 21: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 22: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 23: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 26: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 27: use: command not found
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 30: syntax error near unexpected token `('
/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent: line 30: `my %switches = (readLocalSettings=>0);'

Even though the shebang is much shorter now:

# head /nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/bin/latexindent
#!/nix/store/vk301av7nr86gpql9hpxcw4j9nbr9vms-perl-5.28.2-env/bin/perl -I/nix/store/65h67v6ilwvjp8xqrr73q0yhw4rdhpaa-perl-5.28.2/lib/perl5/site_perl -I/nix/store/vk301av7nr86gpql9hpxcw4j9nbr9vms-perl-5.28.2-env/lib/perl5/site_perl -I/nix/store/65h67v6ilwvjp8xqrr73q0yhw4rdhpaa-perl-5.28.2/lib/perl5/site_perl -I/nix/store/vk301av7nr86gpql9hpxcw4j9nbr9vms-perl-5.28.2-env/lib/perl5/site_perl -I/nix/store/65h67v6ilwvjp8xqrr73q0yhw4rdhpaa-perl-5.28.2/lib/perl5/site_perl -I/nix/store/vk301av7nr86gpql9hpxcw4j9nbr9vms-perl-5.28.2-env/lib/perl5/site_perl -I/nix/store/3xz409mpls1cm5yg768zwcwdnkhbx27h-perl5.28.2-texlive-latexindent-3.5.3/lib/perl5/site_perl
#   latexindent.pl, version 3.5.3, 2018-10-13
#
#       This program is free software: you can redistribute it and/or modify
#       it under the terms of the GNU General Public License as published by
#       the Free Software Foundation, either version 3 of the License, or
#       (at your option) any later version.
#
#       This program is distributed in the hope that it will be useful,
#       but WITHOUT ANY WARRANTY; without even the implied warranty of